Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop dependency on cryptography library in wallet module #3534

Merged
merged 2 commits into from Jan 17, 2022
Merged

Drop dependency on cryptography library in wallet module #3534

merged 2 commits into from Jan 17, 2022
+37 −23

Conversation

eukreign
Copy link
Member

@eukreign eukreign commented Jan 1, 2022 •
edited

fixes #3532

@eukreign eukreign added area: wallet type: improvement Existing (or partially existing) functionality needs to be changed labels Jan 1, 2022
@kauffj kauffj requested a review from shyba January 5, 2022 16:07
@lbry-bot lbry-bot assigned shyba and unassigned eukreign Jan 5, 2022
@coveralls
Copy link

coveralls commented Jan 7, 2022 •
edited

Coverage Status

Coverage remained the same at 69.687% when pulling 302461b on normalize_signatures into f78e382 on master.

shyba
shyba requested changes Jan 7, 2022
View reviewed changes
lbry/wallet/bip32.py Show resolved Hide resolved
@lbry-bot lbry-bot assigned eukreign and unassigned shyba and eukreign Jan 7, 2022
@eukreign eukreign assigned shyba and unassigned eukreign Jan 10, 2022
@lbry-bot lbry-bot assigned eukreign and unassigned shyba Jan 10, 2022
@eukreign eukreign requested a review from shyba January 17, 2022 16:10
@lbry-bot lbry-bot assigned shyba and unassigned eukreign and shyba Jan 17, 2022
@eukreign eukreign merged commit b5ead91 into master Jan 17, 2022
@eukreign eukreign deleted the normalize_signatures branch January 17, 2022 18:38
@jackrobison jackrobison changed the title drop dependency on cryptography library in wallet module Drop dependency on cryptography library in wallet module Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyba shyba shyba approved these changes

Assignees

@eukreign eukreign

Labels
area: wallet type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

investigate: ecdsa created signatures do not validate with coincurve
3 participants
@eukreign @coveralls @shyba