DHT: improve iterative find #3562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyba
added
area: DHT
type: improvement
jackrobison
reviewed
Feb 16, 2022
| self.exclude = exclude or [] | ||
|
|
||
| self.active: typing.Set['KademliaPeer'] = set() | ||
| self.active: typing.Dict['KademliaPeer', int] = {} # peer: distance, sorted |
There was a problem hiding this comment.
should be an ordered dict to be explicit
jackrobison
reviewed
Feb 16, 2022
| self.delayed_call.cancel() # ensure anything scheduled gets cancelled | ||
| self._search_round() | ||
| #if self.running: | ||
| # self.delayed_call = self.loop.call_later(delay, self._search) |
There was a problem hiding this comment.
can delayed_call be deleted?
jackrobison
reviewed
Feb 16, 2022
| self.tasks.append(self.loop.create_task(self._search_task(0.0))) | ||
| for peer in [peer for peer, task in self.running_probes.items() if task.done() or task == t]: | ||
| del self.running_probes[peer] | ||
| self._search_task(0.0) |
There was a problem hiding this comment.
the delay isn't needed as an arg anymore
jackrobison
reviewed
Feb 16, 2022
|
|
||
| def _search(self): | ||
| self.tasks.append(self.loop.create_task(self._search_task())) | ||
| self._search_task() |
jackrobison
reviewed
Feb 16, 2022
| @@ -4885,20 +4885,16 @@ async def jsonrpc_blob_delete(self, blob_hash): | |||
| """ | |||
|
|
|||
| @requires(DHT_COMPONENT) | |||
| async def jsonrpc_peer_list(self, blob_hash, search_bottom_out_limit=None, page=None, page_size=None): | |||
There was a problem hiding this comment.
this should be documented as a breaking change
jackrobison
removed
type: improvement
shyba
added
type: improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max_resultclosest nodes) = less packets, same precision, more concurrency expecteddepends: #3559