Android tests refactoring #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jackrobison Updated raised errors and tests as per your comments in Slack. |
kaykurokawa
reviewed
Oct 16, 2017
| if not int(time.time()) - ts < 600: | ||
| raise AssertionError() | ||
| if not spot > 0: | ||
| raise AssertionError() | ||
| self.currency_pair = (market[0:3], market[3:6]) |
There was a problem hiding this comment.
might as well make these of type ValueError for clarity (first is because timestamp is too dated, second is because spot must be more than 0)
|
Is there a reason android must be compiled with PYTHONOPTIMIZE flag? |
I'm not sure what the exact reason is as it is a setting from the default kivy / python for android app launcher build. I tried to remove it but that resulted in errors launching the Python modules when trying to run the app. |
akinwale
force-pushed
the
android_tests_refactoring
branch
from
3ee6a9f
to
e522e7e
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PYTHONOPTIMIZEflag set for the Android build.__doc__attribute isNonein cases where the docstring isn't present (also due to thePYTHONOPTIMIZEflag)