Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch thumbnail hosting away from berk.ninja #14

Closed
kauffj opened this issue May 22, 2018 · 3 comments
Closed

Switch thumbnail hosting away from berk.ninja #14

kauffj opened this issue May 22, 2018 · 3 comments
Assignees
Labels
priority: high Work needs to be moved into sprint ASAP

Comments

@kauffj
Copy link
Member

kauffj commented May 22, 2018

This is not a good choice long-term. Ideally it would be spee.ch.

@alyssaoc alyssaoc added the priority: high Work needs to be moved into sprint ASAP label Sep 19, 2018
@nikooo777 nikooo777 added this to the Oct 3rd (API) milestone Sep 27, 2018
@nikooo777
Copy link
Collaborator

nikooo777 commented Oct 3, 2018

I'd like to have a discussion on this.
I disagree that we should use spee.ch for thumbnails, but I agree that we should use a better domain in place of berk.ninja

I can discuss this at the office with Jeremy but my TL;dr would be that if we're not doing it in a completely decentralized way then we should just stick to a centralized solution that we know works fine and will work fine.
using spee.ch would only cause a burden because for each single claim we need a second claim just for the thumbnail, we'd be polluting the blockchain with content that is strictly necessary (possibly considered metadata) of another claim, on top of that, we'd depend on spee.ch being online and working forever (both the domain and the infrastructure) rather than just worrying about the domain and the data being on S3 (easily moved/replaced).

I don't see this solution scaling well and could become a huge problem in the future, so either we bundle the thumbnail with the claim (so that the thumbnail itself is part of the blobs associated) or we use the centralized solution.

edit: this ended up not being a tl;dr....

@lyoshenka lyoshenka assigned kauffj and unassigned nikooo777 Oct 3, 2018
@lyoshenka
Copy link
Member

I agree with niko - putting this on spee.ch means we're making two claims for each upload. It also means if spee.ch goes down, all of the thumbnails will break. Are we committed to spee.ch being up with some SLA? I thought we still use it for testing things, running advanced SDK builds, etc.

@alyssaoc
Copy link

alyssaoc commented Nov 1, 2018

Issue moved to lbryio/ytsync #7 via ZenHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high Work needs to be moved into sprint ASAP
Projects
None yet
Development

No branches or pull requests

4 participants