Ensure bool is allocated for later assignment(s)

lbryio · Jul 16, 2018 · 30c6569 · 30c6569
1 parent 84542d9
commit 30c6569
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 12 deletions.
diff --git a/reproducible_build.sh b/reproducible_build.sh
@@ -360,13 +360,7 @@ function build_lbrycrd() {
 		LDFLAGS="${LDFLAGS}" \
 		CPPFLAGS="${CPPFLAGS}" >> "${LBRYCRD_LOG}" 2>&1
     background make "${LBRYCRD_LOG}" "Waiting for lbrycrd to finish building"
-    # Looking into this error on OS X
-    ## tests don't work on OSX. Should definitely figure out why
-    ## that is but, for now, not letting that stop the rest
-    ## of the build
-    #if [ "${OS_NAME}" = "linux" ]; then
-        src/test/test_lbrycrd
-    #fi
+    src/test/test_lbrycrd
     strip src/lbrycrdd
     strip src/lbrycrd-cli
     strip src/lbrycrd-tx

diff --git a/src/test/claimtrie_tests.cpp b/src/test/claimtrie_tests.cpp
@@ -84,9 +84,9 @@ void AddToMempool(CMutableTransaction& tx)
     //BOOST_CHECK(CheckSequenceLocks(tx, STANDARD_LOCKTIME_VERIFY_FLAGS, &lp));
     //mempool.addUnchecked(tx.GetHash(), CTxMemPoolEntry(tx, 0, GetTime(), 111.1, chainActive.Height(), mempool.HasNoInputsOf(tx), 10000000000, false, nSigOps, lp));
     CValidationState state;
-    bool *fMissingInputs;
+    bool fMissingInputs;
     CFeeRate txFeeRate = CFeeRate(0);
-    BOOST_CHECK(AcceptToMemoryPool(mempool, state, tx, false, fMissingInputs, &txFeeRate));
+    BOOST_CHECK(AcceptToMemoryPool(mempool, state, tx, false, &fMissingInputs, &txFeeRate));
     //TestMemPoolEntryHelper entry;
     //entry.nFee = 11;
     //entry.dPriority = 111.0;

diff --git a/src/test/claimtriebranching_tests.cpp b/src/test/claimtriebranching_tests.cpp
@@ -200,10 +200,9 @@ struct ClaimTrieChainFixture{
         }
 
         CValidationState state;
-        bool *fMissingInputs;
+        bool fMissingInputs;
         CFeeRate txFeeRate = CFeeRate(0);
-        BOOST_CHECK(AcceptToMemoryPool(mempool, state, tx, false, fMissingInputs, &txFeeRate));
-
+        BOOST_CHECK(AcceptToMemoryPool(mempool, state, tx, false, &fMissingInputs, &txFeeRate));
     }
 
     //spend a bid into some non claimtrie related unspent