Claim name normalization #102
Conversation
src/claimtrie.cpp
Outdated
| @@ -282,29 +290,31 @@ bool CClaimTrie::haveClaimInQueue(const std::string& name, const COutPoint& outP | |||
| { | |||
| return false; | |||
| } | |||
| const std::string normalized_name = lbryNormalize(name, CHECK_HEIGHT(nValidAtHeight)); | |||
There was a problem hiding this comment.
it looks like all the vars here are camelCase. should normalized_name be normalizedName?
lbrynaut
force-pushed
the
normalized-name-fork
branch
26 times, most recently
from
08c57a7
to
22c96da
Compare
lbrynaut
force-pushed
the
normalized-name-fork
branch
9 times, most recently
from
0c68ab9
to
8a25f6a
Compare
lbrynaut
force-pushed
the
normalized-name-fork
branch
from
8a25f6a
to
8377e18
Compare
| @@ -23,6 +28,9 @@ | |||
| #define SUPPORT_QUEUE_NAME_ROW 'p' | |||
| #define SUPPORT_EXP_QUEUE_ROW 'x' | |||
|
|
|||
| // hard fork height for claim name normalization | |||
| static const int LBRY_NORMALIZED_NAME_FORK_HEIGHT = 329320; | |||
|
|
|||
There was a problem hiding this comment.
We should make this adjustable via chainparams.cpp so that we can define different block height for testing in regtest/testnet
|
@lbrynaut what are the next steps here? |
|
@tzarebczan 1) The required ICU dependency build issue needs to be resolved (last I heard, not by me), 2) Unit tests need to be added, 3) Feedback needs to be applied. I'd say it's stalled at the moment due to 1). I will resolve it eventually it if no one else does after some other work is complete. If someone else resolves it, let me know and I'll move on to 2). |
|
Apologies, I brought this up with the team but was unclear in who was responsible. @IGassmann is going to look at #111 and see if he can crack this build issue. If not, he will escalate to Grin or Kay. |
|
@lbrynaut can 2 and 3 progress without 1? |
|
@kauffj yes |
|
@lbrynaut - to be clear, users will still be allowed to create claims with capital letters but this will ensure that the vanity/permanent URL resolution does not take into account case sensitivity? |
|
@tzarebczan Users can create whatever they want, but internally, claim names are stored/referenced in a normalized way. So you could specify Test, tEst, TEST, tesT, which would all refer to the same claim after the fork. When I have time, I'll clean this up and add some unit tests to demonstrate. |
|
I, unfortunately, wasn't able to resolve the build issue by now. Either @lyoshenka or @kaykurokawa should be able to resolve it more effectively. If any help is needed for the Travis configuration, I'm available. |
|
Heads up -- I've been revisiting this and I think I'm going to abandon this work in favor of a new proposal. This approach has a lot of boundary conditions that are difficult to narrow down, cannot perform as well as I'd like, and may be overly complicated (in retrospect). |
|
can we close this in favor of #159 ? |
Yes. |
Add lowercase and unicode normalization to claim name entries in the claim trie
Related to #65