Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using a pre-existing feature.xml #2

Open
jvz opened this issue Mar 4, 2016 · 3 comments
Open

Add support for using a pre-existing feature.xml #2

jvz opened this issue Mar 4, 2016 · 3 comments

Comments

@jvz
Copy link

jvz commented Mar 4, 2016

There are two facets to this:

  1. Include or merge together (if possible) src/main/feature/feature.xml (configurable location?) with the inline feature XML slurper thing into a kar file.
  2. Allow the feature.xml file to be interpolated with gradle properties like how karaf-maven-plugin works. The standard interpolation was ${foo} and @foo@.
@jvz
Copy link
Author

jvz commented Mar 23, 2016

By the way, I've since migrated to doing it all in-gradle, but this feature is still useful for users migrating from the maven karaf plugin.

@lburgazzoli
Copy link
Owner

Yep, I hope to have time to implement it once main functionalities are stable and documented

@tonit
Copy link
Contributor

tonit commented Mar 13, 2017

Hi, you may prioritize this again since even karaf core developers tend to hand-roll feature.xmls these days. The only thing for your plugin would be to support extend the dsl to support this either by configuration or convention (say, pick up the feature.xml at a known location). You may also include a way to disable merging (as discussed in this item). All i really would need is a way to tell the plugin here is the xml, pls attach it to the gradle results and maybe use it when baking a kar file (though this is not needed for me..)

lburgazzoli pushed a commit that referenced this issue May 15, 2017
Merge latest master branch into our fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants