refactor: use struct instantiation value

lc · Jul 14, 2023 · 6ad0592 · 6ad0592
1 parent 7097804
commit 6ad0592
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 13 deletions.
diff --git a/pkg/providers/otx/otx.go b/pkg/providers/otx/otx.go
@@ -47,7 +47,7 @@ func (c *Client) Name() string {
 
 func (c *Client) Fetch(ctx context.Context, domain string, results chan string) error {
 paginate:
-	for page := 1; ; page++ {
+	for page := uint(1); ; page++ {
 		select {
 		case <-ctx.Done():
 			break paginate
@@ -75,7 +75,7 @@ paginate:
 	return nil
 }
 
-func (c *Client) formatURL(domain string, page int) string {
+func (c *Client) formatURL(domain string, page uint) string {
 	category := "hostname"
 	if !domainutil.HasSubdomain(domain) {
 		category = "domain"

diff --git a/pkg/providers/urlscan/urlscan.go b/pkg/providers/urlscan/urlscan.go
@@ -42,7 +42,7 @@ func (c *Client) Fetch(ctx context.Context, domain string, results chan string)
 	}
 
 paginate:
-	for page := 0; ; page++ {
+	for page := uint(0); ; page++ {
 		select {
 		case <-ctx.Done():
 			break paginate

diff --git a/pkg/providers/wayback/wayback.go b/pkg/providers/wayback/wayback.go
@@ -22,11 +22,8 @@ type Client struct {
 	config  *providers.Config
 }
 
-func New(c *providers.Config, filters providers.Filters) *Client {
-	return &Client{
-		filters: filters,
-		config:  c,
-	}
+func New(config *providers.Config, filters providers.Filters) *Client {
+	return &Client{filters, config}
 }
 
 func (c *Client) Name() string {
@@ -69,11 +66,9 @@ func (c *Client) Fetch(ctx context.Context, domain string, results chan string)
 			}
 
 			// output results
-			for i, entry := range result {
-				// Skip first result by default
-				if i != 0 {
-					results <- entry[0]
-				}
+			// Slicing as [1:] to skip first result by default
+			for _, entry := range result[1:] {
+				results <- entry[0]
 			}
 		}
 	}