Skip to content

Commit

Permalink
[Security Solution] Reduces noise in tests by mocking additional Quer…
Browse files Browse the repository at this point in the history
…yClient functions (elastic#175266)

## Summary

After elastic#174317, some of our
Security Solution tests got quite noisy with the following errors:


<p align="center">
<img width="700"
src="https://github.com/elastic/kibana/assets/2946766/c3a31a3e-e9f2-4b5b-97f7-097bee517d02"
/>
</p> 


This PR adds additional mocks to the SecuritySolution `QueryClient` to
quiet the noise. Note, there was no underlying issue here, I had just
missed adding these new mocks to the main SecuritySolution QueryClient
(they were added to the [other
one](https://github.com/elastic/kibana/pull/174317/files#diff-f6898b396527248e4f5b8fcb0a87d917e9787ca3956dbae9afbfdc093b977e57R42-R47)
within detections).


## Testing

To test, run one of the offending tests locally and ensure you don't see
the above errors, e.g. from kibana root:

```bash
node scripts/jest.js --runTestsByPath x-pack/plugins/security_solution/public/detection_engine/rule_management_ui/pages/coverage_overview/coverage_overview_dashboard.test.tsx
```

<p align="center">
<img width="700"
src="https://github.com/elastic/kibana/assets/2946766/a14460bf-214e-42b5-a1dd-6c3557bf38a7"
/>
</p> 

### Checklist

Delete any items that are not applicable to this PR.

- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
  • Loading branch information
spong authored and lcawl committed Jan 26, 2024
1 parent f37c576 commit 0322704
Showing 1 changed file with 5 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,11 @@ export const TestProvidersComponent: React.FC<Props> = ({
retry: false,
},
},
logger: {
log: jest.fn(),
warn: jest.fn(),
error: () => {},
},
});

return (
Expand Down

0 comments on commit 0322704

Please sign in to comment.