Skip to content

Commit

Permalink
server/drivers/g15: Remove bogus init of buffer[0] with G15_LCD_WRITE…
Browse files Browse the repository at this point in the history
…_CMD

G15_LCD_WRITE_CMD needs to send to the g15daemon *once* not as part of
every frame, since we pass G15_G15RBUF to new_g15_screen, this is already
done for us by new_g15_screen.

buffer[0] contains the first 8 pixels of the first column of the display
and setting this to G15_LCD_WRITE_CMDn makes no sense what so ever.
This code was not causing problems because we do a g15r_clearScreen later
on which undoes it, but it is totally bogus, so lets remove it.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
  • Loading branch information
jwrdegoede authored and haraldg committed Jun 9, 2019
1 parent 03a05d5 commit 2a102b6
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions server/drivers/g15.c
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,6 @@ MODULE_EXPORT int g15_init (Driver *drvthis)

g15r_initCanvas(p->canvas);
g15r_initCanvas(p->backingstore);
p->canvas->buffer[0] = G15_LCD_WRITE_CMD;
p->backingstore->buffer[0] = G15_LCD_WRITE_CMD;

return 0;
}
Expand Down

0 comments on commit 2a102b6

Please sign in to comment.