Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for requiresConversationResolution #383

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

sindrig
Copy link
Contributor

@sindrig sindrig commented May 21, 2024

If requiresConversationResolution is set then update-branch will attempt to merge unmergeable pull requests if there are any unresolved conversations on the pull request. This takes this setting into account.

If requiresConversationResolution is set then update-branch will
attempt to merge unmergeable pull requests if there are any
unresolved conversations on the pull request. This takes this setting
into account.
This only includes review comments, not regular comments on pull
requests.
Copy link
Owner

@lcdsmao lcdsmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lcdsmao lcdsmao merged commit 77fcb7e into lcdsmao:main May 29, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants