Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SafeConfigParser renamed to ConfigParser #46

Merged
merged 2 commits into from
Aug 11, 2018
Merged

fix: SafeConfigParser renamed to ConfigParser #46

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c96410e
fix: SafeConfigParser renamed to ConfigParser
Aug 6, 2018
9ee4a32
Update archey3
Aug 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions archey3
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,7 @@ class systemUpgrade(display):

#------------ Config -----------

class ArcheyConfigParser(configparser.SafeConfigParser):
class ArcheyConfigParser(configparser.ConfigParser):
"""
A parser for the archey config file.
"""
Expand Down Expand Up @@ -802,7 +802,6 @@ class Archey(object):
args = ()

yield groups["func"], args
raise StopIteration
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would argue that this shouldn't be removed, but just changed to return

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not keen with python, so let author decide

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine.


def format_item(self, item):
title = item[0].rstrip(':')
Expand Down