-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rayonix fixes and some mrxv functions #71
Conversation
Tasks have been updated in terms of output nomenclature and using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that starts to look like something! Thanks so much @apeck12 , I'll make good use of all this today :D
Just a thought: do we want to rename misc/metrology.py
as interfaces/metrology_interface.py
?
@@ -29,3 +31,27 @@ def __getattr__(self, item): | |||
return self.__getitem__(item) | |||
except KeyError: | |||
raise AttributeError(item) | |||
|
|||
def fetch_latest(fnames, run): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for later: this could potentially go with another function tasked with defining paths to mrxv, etc. based on the location (SLAC, NERSC, ...). Maybe in some path_interface
tool, or something
I will merge now, hope it's OK! |
@fredericpoitevin, thanks for merging! I'll put metrology.py into interfaces and rename the contents of interfaces as we discussed earlier (e.g. stream_interface.py -> istream.py) in a separate PR. |
Most of the changes make the code compatible with the Rayonix.
In addition,
retrieve_from_mrxv
function and associatedfetch_mask
task were implemented. Theopt_distance
task now detects the appropriate mask file using afetch_latest
function added to shortcuts.