Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Korean: FKR171-179 #18

Closed
scossu opened this issue Jun 15, 2023 · 1 comment
Closed

Korean: FKR171-179 #18

scossu opened this issue Jun 15, 2023 · 1 comment
Assignees
@hyoungl
Milestone
Phase 2

Comments

@scossu
Copy link
Collaborator

scossu commented Jun 15, 2023

In the original K-Romanizer, a common logic of FKR 171 to 179, is to replace a Hangul character with a Roman X, e.g.

   If StringInStr($Hangul,"不")>0 THEN
	  StringReplace($Hangul,"不","X")

I don't see this X being replaced anywhere else in Functions_KoreanHancha.au3 nor in Function_KoreanRomanizer.au3. Is this intentional?
@scossu
Copy link
Collaborator Author

scossu commented Jun 20, 2023 •
edited
Loading

Never mind. I figured out the logic. The replace operation is not affecting the original string and it's only counting the indices of occurrences of 不.

@scossu scossu closed this as completed Jun 20, 2023
@scossu scossu added this to the Phase 2 milestone Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hyoungl hyoungl

Labels
None yet
Projects
None yet
Milestone
Phase 2
Development

No branches or pull requests
2 participants
@scossu @hyoungl