-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Korean: Name test failures #49
Comments
Looking at this error list I can't figure out if there is a number of logical errors or if it's a matter of adding some exception rules. This one stands out as a possible error in the test string:
I haven't seen the comma notation elsewhere. Was that intended? |
It is actually a very simple logic. |
The notation you mentioned is for a different situation, where cataloging rules (not romanization rules) require a comma between the last name and the first name. This function should not turn on globally, because it applies only to certain fields like 100, 600, 700, etc. |
Right, I was referring to the comma in the result rather than in the source. So, the resolution for If you think that an extra option may be necessary for adding a comma in specific fields, I can add it. I tried to avoid per-script options so far, but if it's necessary, I'll add it. |
Basically, there should not be a comma between the first name and the last name. |
I added an option to specify the MARC field for Korean names. If the value is one of those you indicate, the Romanized text will add a comma after the last name. |
Current list of failing names (from Y. Lee's list:
korean_names_tests.log
The text was updated successfully, but these errors were encountered: