Make FrozenClock mutable through setter #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcobucci
requested changes
Jan 19, 2018
src/FrozenClock.php
Outdated
| @@ -18,6 +18,11 @@ public function __construct(DateTimeImmutable $now) | |||
| $this->now = $now; | |||
| } | |||
|
|
|||
| public function setTo(DateTimeImmutable $now) | |||
test/FrozenClockTest.php
Outdated
| * @test | ||
| * | ||
| * @covers \Lcobucci\Clock\FrozenClock::setTo | ||
| * @covers \Lcobucci\Clock\FrozenClock::now |
There was a problem hiding this comment.
\Lcobucci\Clock\FrozenClock::now should be marked as @uses instead of @covers.
There was a problem hiding this comment.
We also need to add @uses \Lcobucci\Clock\FrozenClock::__construct
Because the FrozenClock is often injected in other objects during testing, being able to change the current time on the FrozenClock without reinjecting it in the object under test is quite useful.
lcobucci
approved these changes
Jan 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the FrozenClock is often injected in other objects during
testing, being able to change the current time on the FrozenClock
without reinjecting it in the object under test is quite useful.