Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for JwtFacade #853

Merged
merged 8 commits into from Jul 24, 2022
Merged

Add documentation for JwtFacade #853

merged 8 commits into from Jul 24, 2022

Conversation

lcobucci
Copy link
Owner

This adds documentation for the component whilst applying some minor improvements to make it more flexible.

Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
This is meant to align the configuration between different PHP versions.

Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
Aiming to restrict the amount of types handled by that method, this
reduces the parameter to a single type.

Users are able to use `Closure::fromCallable('doSomething')` or
`doSomething(...)` (PHP 8.1+) to use named functions as the source for
the customisation.

Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
This makes the facade a little more flexible for testing purposes and
allows users to reduce the amount of customisation needed on their code.

Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
This makes it easier for users to get the links to sections of the
documentation - otherwise people have to guess based on the title.
Using footnotes allows a more fluid reading of the docs.
Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
@lcobucci lcobucci added this to the 4.2.0 milestone Jul 24, 2022
@lcobucci lcobucci self-assigned this Jul 24, 2022
@lcobucci lcobucci merged commit fa8cbfc into 4.2.x Jul 24, 2022
@lcobucci lcobucci deleted the facade-improvements branch July 24, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant