Implemented visit_AsyncFunctionDef in the AST->ASR visitor #2442

ujjwaltwitx · 2023-12-11T10:44:00Z

Solves issue no #2312. Implemented visit_AsyncFunctionDef function both in the SymbolTableVisitor and BodyVisitor class.

certik · 2023-12-12T20:59:07Z

src/lpython/semantics/python_ast_to_asr.cpp

+        try
+        {
+            // to be implemented
+        }
+        catch(const std::exception& e)
+        {
+            std::cerr << e.what() << '\n';
+        }        


You have to report the error like this:

Suggested change

try

{

// to be implemented

}

catch(const std::exception& e)

{

std::cerr << e.what() << '\n';

}

throw SemanticError("The `async` keyword is currently not supported", x.base.base.loc);

Thanks @certik. I will make the necessary changes

certik · 2023-12-12T21:00:50Z

src/lpython/semantics/python_ast_to_asr.cpp

+            std::cerr << e.what() << '\n';
+        }
+
+    }


Instead of declaring it twice, declare it just once in the base class.

Remove this function completely.

certik · 2023-12-12T21:01:07Z

Let's also add a test for this in tests/errors.

ujjwaltwitx · 2023-12-13T10:12:58Z

Let's also add a test for this in tests/errors.

@certik , can you please guide me a bit on how to add the test for the async implementation in tests/errors. I have created the file test_async.py and it contains the below given code

async def test_async():
    print("done")

test_async()

But when I run ./run_tests.py, the file doesn't get executed.

certik · 2023-12-13T16:02:59Z

You have to add it to tests/tests.toml

certik · 2023-12-13T21:13:50Z

src/lpython/semantics/python_ast_to_asr.cpp

+        try
+        {
+            // to be implemented
+        }
+        catch(const std::exception& e)
+        {
+            std::cerr << e.what() << '\n';
+        }


Remove these.

certik · 2023-12-13T21:15:28Z

src/lpython/semantics/python_ast_to_asr.cpp

+            std::cerr << e.what() << '\n';
+        }
+        throw SemanticError("The `async` keyword is currently not supported", x.base.base.loc);
+    }


Move the function to the CommonVisitor.

certik · 2023-12-13T21:15:50Z

Very good, it's almost done. Left couple more comments.

certik · 2023-12-14T15:55:03Z

src/lpython/semantics/python_ast_to_asr.cpp

@@ -4051,6 +4056,8 @@ class SymbolTableVisitor : public CommonVisitor<SymbolTableVisitor> {
    // Implement visit_Global for Symbol Table visitor.
    void visit_Global(const AST::Global_t &/*x*/) {}

+
+


Remove white space.

certik · 2023-12-14T15:55:10Z

src/lpython/semantics/python_ast_to_asr.cpp

@@ -4823,6 +4830,7 @@ class BodyVisitor : public CommonVisitor<BodyVisitor> {
        tmp = nullptr;
    }

+


remove white space

certik · 2023-12-14T15:55:41Z

It looks good! Last two issues, see my comments above.

certik

This looks great now, thank you!

…ementation

…unctionDef function from BodyVisitor and moved the function to common visitor

…s#2442)

certik reviewed Dec 12, 2023

View reviewed changes

certik marked this pull request as draft December 12, 2023 20:59

certik reviewed Dec 12, 2023

View reviewed changes

ujjwaltwitx marked this pull request as ready for review December 13, 2023 19:11

certik reviewed Dec 13, 2023

View reviewed changes

certik marked this pull request as draft December 13, 2023 21:15

ujjwaltwitx marked this pull request as ready for review December 14, 2023 07:05

certik reviewed Dec 14, 2023

View reviewed changes

certik approved these changes Dec 14, 2023

View reviewed changes

ujjwaltwitx added 5 commits December 14, 2023 09:41

Implemented visit_AsyncFunctionDef in the AST->ASR visitor

6f93c43

Removed unused parameters

6737a06

Added appropriate throw block for error and added test for async impl…

0f4dc32

…ementation

removed unnecessary lines from the function, removed the visit_AsyncF…

3ee163e

…unctionDef function from BodyVisitor and moved the function to common visitor

Removed whitespaces

31ccd83

certik force-pushed the visit_async branch from d92662d to 31ccd83 Compare December 14, 2023 16:41

certik enabled auto-merge (squash) December 14, 2023 16:41

certik merged commit 2afa365 into lcompilers:main Dec 14, 2023
13 checks passed

ujjwaltwitx deleted the visit_async branch December 14, 2023 17:41

syheliel mentioned this pull request Feb 16, 2024

Internal Compiler Error: Unhandled exception #2312

Closed

Agent-Hellboy pushed a commit to Agent-Hellboy/lpython that referenced this pull request Mar 5, 2024

Implemented visit_AsyncFunctionDef in the AST->ASR visitor (lcompiler…

bef8f4c

…s#2442)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented visit_AsyncFunctionDef in the AST->ASR visitor #2442

Implemented visit_AsyncFunctionDef in the AST->ASR visitor #2442

ujjwaltwitx commented Dec 11, 2023

certik Dec 12, 2023 •

edited

ujjwaltwitx Dec 13, 2023

certik Dec 12, 2023

certik Dec 13, 2023

certik commented Dec 12, 2023

ujjwaltwitx commented Dec 13, 2023

certik commented Dec 13, 2023

certik Dec 13, 2023

certik Dec 13, 2023

certik commented Dec 13, 2023

certik Dec 14, 2023

certik Dec 14, 2023

certik commented Dec 14, 2023

certik left a comment

		@@ -4051,6 +4056,8 @@ class SymbolTableVisitor : public CommonVisitor<SymbolTableVisitor> {
		// Implement visit_Global for Symbol Table visitor.
		void visit_Global(const AST::Global_t &/x/) {}

		@@ -4823,6 +4830,7 @@ class BodyVisitor : public CommonVisitor<BodyVisitor> {
		tmp = nullptr;
		}

Implemented visit_AsyncFunctionDef in the AST->ASR visitor #2442

Implemented visit_AsyncFunctionDef in the AST->ASR visitor #2442

Conversation

ujjwaltwitx commented Dec 11, 2023

certik Dec 12, 2023 • edited

Choose a reason for hiding this comment

ujjwaltwitx Dec 13, 2023

Choose a reason for hiding this comment

certik Dec 12, 2023

Choose a reason for hiding this comment

certik Dec 13, 2023

Choose a reason for hiding this comment

certik commented Dec 12, 2023

ujjwaltwitx commented Dec 13, 2023

certik commented Dec 13, 2023

certik Dec 13, 2023

Choose a reason for hiding this comment

certik Dec 13, 2023

Choose a reason for hiding this comment

certik commented Dec 13, 2023

certik Dec 14, 2023

Choose a reason for hiding this comment

certik Dec 14, 2023

Choose a reason for hiding this comment

certik commented Dec 14, 2023

certik left a comment

Choose a reason for hiding this comment

certik Dec 12, 2023 •

edited