Config: Added zstd-static package to the conda environment configuration files
#2540
Conversation
environment_unix.yml
Outdated
| - toml | ||
| - zlib | ||
| - git | ||
| - flex |
There was a problem hiding this comment.
Why is flex needed? I don't think it's needed.
There was a problem hiding this comment.
Oh. I am sorry for the mistake. I recall installing flex when I ran into an error with bison. I recalled this thread.
I am making the amends.
kmr-srbh
changed the title
flex and zstd-static packages to all conda environment configuration files.zstd-static packages to all conda environment configuration files.
kmr-srbh
changed the title
zstd-static packages to all conda environment configuration files.zstd-static package to the conda environment configuration files.
|
@certik Could you please investigate as to why one of the above test failed? I checked the log and the workflow file. Nothing seems to explain the reason for only 1 test failing for |
|
The failure is due to #2542. |
| - ninja | ||
| - numpy | ||
| - xonsh | ||
| - flake8 |
There was a problem hiding this comment.
I am unsure of the changes in conda for windows.
There was a problem hiding this comment.
In both the files, only the zstd-static package was added.
| - cmake | ||
| - numpy | ||
| - flake8 | ||
| - setuptools | ||
| - bison=3.4 |
There was a problem hiding this comment.
Is it needed to change the order of specifying dependencies here? It seems hard to interpret which packages where removed and which ones were added.
There was a problem hiding this comment.
I am sorry for the inconvenience. I did this to improve readability.
| @@ -36,16 +36,10 @@ Follow the steps below to install and run LPython on Linux, Windows or macOS. | |||
|
|
|||
| - ### Set up your system | |||
| - Linux | |||
| - Make sure you have `g++` and `cmake` installed. If not, install them using the below command: | |||
| - Run the following command to install some global build dependencies: | |||
There was a problem hiding this comment.
I think the first step in linux should be creating the conda environment. The next step can be installing the required global build dependencies.
Similarly, update for docs/src/installation.md.
There was a problem hiding this comment.
I understand your point @Shaikh-Ubaid, but moving this section will logically separate the conda environment creation part for Linux and Windows. As installing the global dependencies takes some time for a new contributor, I let it remain at the top.
The user can perhaps download Miniforge in the meantime. 😄
There was a problem hiding this comment.
Ok, it seems fine for now.
Moved global package installations to conda environment.
…les. (lcompilers#2540) * Added `flex` and `zstd-static=1.5.5` packages. * Added `flex` and `zstd-static=1.5.5` packages. * Incorporated suggestions from lcompilers#2537 Moved global package installations to conda environment. * Updated README.md to reflect changes suggested in lcompilers#2537 * Remove `flex` * Remove `flex`
…les. (lcompilers#2540) * Added `flex` and `zstd-static=1.5.5` packages. * Added `flex` and `zstd-static=1.5.5` packages. * Incorporated suggestions from lcompilers#2537 Moved global package installations to conda environment. * Updated README.md to reflect changes suggested in lcompilers#2537 * Remove `flex` * Remove `flex`
kmr-srbh
changed the title
zstd-static package to the conda environment configuration files.zstd-static package to the conda environment configuration files
kmr-srbh
changed the title
zstd-static package to the conda environment configuration fileszstd-static package to the conda environment configuration files
Also incorporated changes to installation-docs suggested in #2537 .