Fix duplicate read when paring python asr #2541
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ondřej Čertík <ondrej@certik.us>
|
What is the status of this PR? |
Thirumalai-Shaktivel
previously approved these changes
Mar 5, 2024
Comment on lines
+135
to
+143
| Result<LPython::AST::ast_t*> parse_python_file(Allocator &al, | ||
| const std::string &runtime_library_dir, | ||
| const std::string &infile, | ||
| diag::Diagnostics &diagnostics, | ||
| uint32_t prev_loc, | ||
| [[maybe_unused]] bool new_parser) { | ||
| std::string input_source_code = read_file(infile); | ||
| return parse_python_source(al, runtime_library_dir, input_source_code, diagnostics, prev_loc, new_parser); | ||
| } |
There was a problem hiding this comment.
Instead, refactor the code to not read in parse_python_file function in parser.cpp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #2475. I create
parse_python_sourceto accept source code literal input to avoid additional file read.Note that there are still mutiple codes sharing the similar logic, like https://github.com/lcompilers/lpython/blob/main/src/bin/lpython.cpp#L254 . If this modification is accepted, I will fix them in this PR later.