-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented mangling for c back-end as per issue #2359 . #2546
Conversation
I have refactored the changes as per requirements. |
@certik Are there any other improvements required? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. If it works add a test in integration_tests
and register in CMakeLists. Later, mark it as ready for review.
I have implemented all the suggested changes. Some of the tests failed due to mamba |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Extended the
unique_symbols
pass to mangle reserved keywords for c backend.