Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented mangling for c back-end as per issue #2359 . #2546

Merged
merged 7 commits into from
Mar 23, 2024

Conversation

tanay-man
Copy link
Contributor

Extended the unique_symbols pass to mangle reserved keywords for c backend.

src/bin/lpython.cpp Outdated Show resolved Hide resolved
@tanay-man
Copy link
Contributor Author

I have refactored the changes as per requirements.

@tanay-man
Copy link
Contributor Author

@certik Are there any other improvements required?

Copy link
Collaborator

@Thirumalai-Shaktivel Thirumalai-Shaktivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If it works add a test in integration_tests and register in CMakeLists. Later, mark it as ready for review.

@Thirumalai-Shaktivel Thirumalai-Shaktivel marked this pull request as draft March 7, 2024 05:25
src/bin/lpython.cpp Outdated Show resolved Hide resolved
src/libasr/pass/unique_symbols.cpp Outdated Show resolved Hide resolved
@tanay-man tanay-man marked this pull request as ready for review March 12, 2024 03:54
@tanay-man
Copy link
Contributor Author

I have implemented all the suggested changes. Some of the tests failed due to mamba Error: ENOENT: no such file or directory, lstat '/home/runner/work/_temp/setup-micromamba/micromamba-shell'.

Copy link
Collaborator

@Thirumalai-Shaktivel Thirumalai-Shaktivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

integration_tests/CMakeLists.txt Outdated Show resolved Hide resolved
@Thirumalai-Shaktivel Thirumalai-Shaktivel enabled auto-merge (squash) March 23, 2024 05:58
@Thirumalai-Shaktivel Thirumalai-Shaktivel merged commit c53ffed into lcompilers:main Mar 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants