Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
After installing the rock with the command from the wiki https://github.com/lcpz/lain/wiki
The installation works successfully, but the installed package is broken.
/home/aireone/.luarocks/share/lua/5.4/lain/init.lua:12: module 'lain.layout' not found
points to https://github.com/lcpz/lain/blob/master/init.lua#L12And
ls
in this directory only outputs theinit.lua
file (as expected)According to https://github.com/luarocks/luarocks/wiki/Creating-a-rock#building-a-module, the
modules = { lain = "init.lua" }
configuration tells Luarocks to install only theinit.lua
file.This PR fix the
modules
list and make the rockspec file install all the modules (expectutil/dkjson.lua
which is installed by the required dependencies).It can be tested locally with the installation command (Note to anyone wanting to test that without cloning the repo: you can also use an HTTP URL to the file on GitHub):
After that, the rock can be loaded successfully from an Awesome WM config.
Here is the output
luarocks show lain
gives me. As expected, there is now the full list of modules installed.