Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate problem with reaction annotation regexes #40

Closed
stelmo opened this issue Oct 17, 2022 · 5 comments
Closed

Investigate problem with reaction annotation regexes #40

stelmo opened this issue Oct 17, 2022 · 5 comments
Assignees
@stelmo
Labels
🐛 bug ❓ feedback needed

Comments

@stelmo
Copy link
Collaborator

stelmo commented Oct 17, 2022

Currently the reaction annotation conformity does not work as expected (compare to output from memote.py). I think something is wrong with the regex expressions.
@stelmo stelmo added the 🐛 bug label Oct 17, 2022
@exaexa
Copy link
Collaborator

exaexa commented Oct 18, 2022

example of what's wrong?

@exaexa
Copy link
Collaborator

exaexa commented Nov 12, 2022

Ping, is there an example?

@exaexa exaexa added the ❓ feedback needed label Nov 12, 2022
@stelmo
Copy link
Collaborator Author

stelmo commented Nov 12, 2022

I think this may have been fixed. @Fl-Sch @vm-vh could you compare the annotation output from our tests to that of memote and see if they correspond? If so, then this is fixed

@stelmo stelmo mentioned this issue Nov 12, 2022
Merged
9 tasks
@stelmo
Copy link
Collaborator Author

stelmo commented Nov 12, 2022

Also add negative tests when sure that annotation checks are totally correct/can handle edge cases

@stelmo stelmo self-assigned this Nov 12, 2022
@stelmo
Copy link
Collaborator Author

stelmo commented May 15, 2023

Fixed in #70

@stelmo stelmo closed this as completed May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stelmo stelmo

Labels
🐛 bug ❓ feedback needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@exaexa @stelmo