Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3 support #33

Closed
wants to merge 17 commits into from
Closed

python 3 support #33

wants to merge 17 commits into from

Conversation

kman0
Copy link

@kman0 kman0 commented Nov 23, 2014

Added python3.3 and python 3.4 support.
Added travis integration for tests and tox.ini for testing locally

Ensured all offline tests passed locally as well.

@lczub
Copy link
Owner

lczub commented Nov 24, 2014

Hello MK,

many thanks for your great work. I haven't still work with travis and tox, but the first look on them are interesting. Have you set up a public travis project or local private one?

I need some time to review your changes, so I pull them into a separate new branch Py3 and will report questions / problems as issues, ok? (examples see #34 and #35)

I also set the version info to 0.6.0-dev, cause I think, there will be some additional changes and add you to the the developer list in README.rst. (see c631505)

Cheers Luiko

@kman0
Copy link
Author

kman0 commented Nov 26, 2014

Hi Luiko,
Thanks for adding me to the dev list and the dev branch.

I have fixed the bugs #34 and #35 and made few additonal changes to ensure that all the tests(both offline and online) pass in py26, py27, py33, and py34. I will raise the pull request shortly.

Travis is very simple. You can signin with github and switch ON CI for repositires listed under --> Accounts. The free travis projects are public and you can see mine at (https://travis-ci.org/manojklm/TestLink-API-Python-client)

TOX is even simpler.

  1. Install the desired versions of python (i usually use windows and have not encountered any problems yet)
  2. Go into the folder that has tox.ini and run tox

Regards,
mk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants