Support reproducible builds #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
META-INF/MANIFEST.MF contains values, that make the build harder to reproduce than necessary. Uses gitDescribe with tags, so that SCM-Git-Commit-ID-Description contains the useful information, from which tag this build has been built. Removes SCM-Git-Branch, since this is the current HEAD branch. When initially built, this is master, but when rebuilding, master might have already moved along. The branch info is actually not needed as long as SCM-Git-Commit-ID* properties are provided. Removes Implementation-Build-Java-Vendor and Implementation-Build-Java-Version as these are too specific (e.g. AdoptOpenJDK vs. OpenJDK vs. Oracle and 14.0.1 vs. 14.0.2). Instead the property Implementation-Build-Java-Spec-Version is used.
|
sorry for the long delay, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
META-INF/MANIFEST.MF contains values, that make the build harder
to reproduce than necessary.
Uses gitDescribe with tags, so that SCM-Git-Commit-ID-Description
contains the useful information, from which tag this build has
been built.
Removes SCM-Git-Branch, since this is the current HEAD branch.
When initially built, this is master, but when rebuilding,
master might have already moved along. The branch info
is actually not needed as long as SCM-Git-Commit-ID* properties
are provided.
Removes Implementation-Build-Java-Vendor and
Implementation-Build-Java-Version as these are too specific
(e.g. AdoptOpenJDK vs. OpenJDK vs. Oracle and 14.0.1 vs. 14.0.2).
Instead the property Implementation-Build-Java-Spec-Version is
used.
See also jvm-repo-rebuild/reproducible-central#45