Add one more error code which is LDAP_PARTIAL_RESULTS: 9 #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners
requested changes
Aug 26, 2019
There was a problem hiding this comment.
Error code 9 seems to be a reserved error code -- https://tools.ietf.org/html/rfc4511#section-4.1.9
Can you point me to the server implementation you use that i returning this code? Is it OpenLDAP, a commercial implementation, or your own implementation?
1 similar comment
|
@frostie614 yep. That answers it. A follow-up PR that adds a working integration test would be ideal, but I have no idea how to force it. |
jsumners
approved these changes
Jan 16, 2020
jsumners
added
the
closed-for-v2
|
Please include a minimal reproducible example |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this issue: #366