Remove dtrace-provider from optionalDependencies #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@melloc, what do you think of this? 🙏 |
This was referenced Jun 14, 2019
|
I think this is a good enough start to solve people's issues. I'm also willing to consider a full removal of the dtrace code in the future. |
This was referenced Aug 25, 2019
|
Please include a minimal reproducible example |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #399 and #286 for discussion.
It's pretty clear that dtrace dependency is causing too many problems for its own good. Searching for
dtraceissues on this repository brings up plenty of issues.