Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update travis config #537

Merged
merged 11 commits into from Aug 27, 2019
Merged

Update travis config #537

merged 11 commits into from Aug 27, 2019

Conversation

jsumners
Copy link
Member

No description provided.

Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to use lts/* and node so they don't have to be updated on every new node release.

.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@UziTech
Copy link
Member

UziTech commented Aug 27, 2019

even better use jobs

sudo: false

language: node_js

git:
  depth: 3

branches:
  only:
  - master
  - next

jobs:
  include:
    - stage: test 👩🏽‍💻
      script: npm test
      node_js: node
    - node_js: lts/*

    - stage: lint ✨
      script: npm run lint
      node_js: lts/*

@UziTech
Copy link
Member

UziTech commented Aug 27, 2019

It would be great to have windows tests too

appveyor.yml:

# Test against the latest version of this Node.js version
environment:
  matrix:
    # node.js
    - nodejs_version: "lts"
    - nodejs_version: "stable"

# Install scripts. (runs after repo cloning)
install:
  # Get the latest stable version of Node.js or io.js
  - ps: Install-Product node $env:nodejs_version
  # install modules
  - npm install

# Post-install test scripts.
test_script:
  # Output useful info for debugging.
  - node --version
  - npm --version
  # run tests
  - npm test

# Don't actually build.
build: off

jsumners and others added 5 commits August 27, 2019 14:52
@jsumners
Copy link
Member Author

I had too bad of an experience with AppVeyor when we had it setup on the Fastify org. I have no intention of using that service. I am still waiting to hear from @github about getting Actions enabled for this organization. If that comes through, I intend to switch over to it. For now, I just want to get some basic CI going so we can more easily audit these PRs.

@UziTech
Copy link
Member

UziTech commented Aug 27, 2019

I haven't had great luck with windows on travis. It has been in beta for a few years and it doesn't look like they are working on it too hard.

@jsumners
Copy link
Member Author

🤷‍♂️ this config seems to be running the lts/* tests twice, but I'm merging it. I want to move on to linting.

@jsumners jsumners merged commit d5fa042 into next Aug 27, 2019
@jsumners jsumners deleted the ci-cleanup branch August 27, 2019 19:28
@jsumners
Copy link
Member Author

⚠️ This issue has been locked due to age. If you have encountered a recent
problem that seems to be covered by this issue, please open a new issue.

Please include a minimal reproducible example
when opening a new issue.

@ldapjs ldapjs locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants