Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Remove spaces in searchResEntry objectName #646

Merged
merged 4 commits into from
Jul 29, 2020

Conversation

stenh0use
Copy link
Contributor

@stenh0use stenh0use commented Jul 27, 2020

This PR addresses issue #645

This change fixes how DNs are serialised into BER for searchResEntry messages, and is related to the following other issues and PRs (#611, #613).

The change is required as it breaks clients that are expecting the reply to be comma separated only and not comma space ,

Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Will merge and release when I am able.

@jsumners jsumners merged commit 49d5724 into ldapjs:master Jul 29, 2020
@jsumners
Copy link
Member

⚠️ This issue has been locked due to age. If you have encountered a recent
problem that seems to be covered by this issue, please open a new issue.

Please include a minimal reproducible example
when opening a new issue.

@ldapjs ldapjs locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants