This repository has been archived by the owner on May 14, 2024. It is now read-only.
SearchPager: Implement queueing events until a listener appears #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the same problems for paged searches as does ldapjs#610 for unpaged searches. By passing an EventEmitter via callback there exist cases when events are emitted before listeners are registered, resulting in missed events. The Change turns SearchPager into a CorkedEmitter which is already used as a solution for non paged searches. Doing so requires the internal 'search' event to be dropped. This change adapts a test case originally by László Szűcs (@ifroz). Signed-off-by: Philippe Seewer <philippe.seewer@bfh.ch>
|
Can you run |
UziTech
approved these changes
May 7, 2021
jsumners
reviewed
May 9, 2021
|
Looks like this PR branch is not up-to-date with the target |
jsumners
approved these changes
May 9, 2021
Merged
|
Please include a minimal reproducible example |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the same problems for paged searches as does
#610 for unpaged searches.
By passing an EventEmitter via callback there exist cases when events
are emitted before listeners are registered, resulting in missed
events.
The Change turns SearchPager into a CorkedEmitter which is already
used as a solution for non paged searches. Doing so requires the
internal 'search' event to be dropped.
This change adapts a test case originally by László Szűcs (@ifroz).
Signed-off-by: Philippe Seewer philippe.seewer@bfh.ch