Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a New LdapSchema Class that Represents the Full Schema in Use #29

Open
ChadSikorra opened this issue May 16, 2017 · 0 comments
Open

Comments

@ChadSikorra
Copy link
Contributor

Currently the schema is parsed and converted into separate LdapObjectSchema objects and retrieved via a factory. This is not ideal. It also makes it very hard to use the schema in different areas of the library (such as in converters). To fix this the following should happen:

  • Create a new LdapSchema class. All parsed LdapSchemaObjects for the schema in use should be contained in here.
  • The LdapSchema class should have a setter/getter on the domain configuration. Because ultimately it's associated with the domain connection/configuration.
  • The LdapObjejctSchemaFactory will be replaced by a LdapSchemaFactory.
  • The schema events will somehow need to be carried over or rethought out.

However, this should ultimately help improve caching, remove the need for the LdapObjectSchema in certain constructors, simplify the code, and allow schema types to be used in the attribute converter process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant