Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--disable-verify should be the default #4284

Open
ghost opened this issue Nov 28, 2022 · 5 comments
Open

--disable-verify should be the default #4284

ghost opened this issue Nov 28, 2022 · 5 comments

Comments

@ghost
Copy link

ghost commented Nov 28, 2022

LLVM IR verification is slow.

@JohanEngelen
Copy link
Member

Indeed, it speeds up the build at Weka by about 2%. (total, including SemA and linking)
What's the downside? Silent miscompilation, or (better) crash?

@ghost
Copy link
Author

ghost commented Dec 5, 2022

crash during object emission highly expected.

@FeepingCreature
Copy link
Contributor

FeepingCreature commented Mar 20, 2023

Difference in compilation speed on 1.32.0 with and without --disable-verify:
Screenshot_20230320_130014

Something's probably going pathological.

@JohanEngelen
Copy link
Member

@FeepingCreature can you clarify what the numbers are? Which one is for with, and which without --disable-verify ?

@FeepingCreature
Copy link
Contributor

Jenkins adds new builds at the top. Bottom row is without -disable-verify, top row is with -disable-verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants