Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nerd font not working #10

Closed
dlvhdr opened this issue May 14, 2022 · 8 comments
Closed

Nerd font not working #10

dlvhdr opened this issue May 14, 2022 · 8 comments

Comments

@dlvhdr
Copy link
Contributor

dlvhdr commented May 14, 2022

I'm using FiraCode with Alacritty (terminal emulator) in tmux and the icons don't display properly.
image

@ldelossa
Copy link
Owner

Its possible the config is not working properly. Did you update config "icon_set" value?

@ldelossa
Copy link
Owner

Hey there, so I just checked on my end. The nerd fonts seem to be working OK:

require('litee.gh').setup({
    icon_set = "nerd",
})

Is this your config? Also, do you render the icons here correctly?

https://github.com/ldelossa/litee.nvim/blob/main/lua/litee/lib/icons/init.lua

@dlvhdr
Copy link
Contributor Author

dlvhdr commented May 14, 2022

I tried checking on my repo gh-dash but the plugin was stuck again.
My config uses the defaults, maybe it will work with the nerd option

@ldelossa
Copy link
Owner

@dlvhdr please try again with latest commit and follow #8 - this fixes I think your issue with opening the PR.

@cloudlena
Copy link

cloudlena commented May 16, 2022

I'm using the exact same setup (FiraCode with Alacritty) and for me, it's working fine with the following config:

use({
    "ldelossa/gh.nvim",
    requires = { "ldelossa/litee.nvim" },
    config = function()
        require("litee.lib").setup()
        require("litee.gh").setup({
            icon_set = "nerd",
        })
    end,
})

This works well, but I'm getting nil instead of some icons:

screenshot-2022-05-16-21-51-28

Furthermore, the # icon seems to be misconfigured. Wouldn't it make more sense to just use the # character instead?

@ldelossa
Copy link
Owner

Cool that looks right. I'll fix those nils.

@ldelossa
Copy link
Owner

@cloudlena - Please pull latest "litee.nvim" commit. this will fix those nils.

@cloudlena
Copy link

Thanks, @ldelossa. The nils are indeed fixed 👍

ldelossa added a commit that referenced this issue Jul 22, 2022
to get around #10 each node in the tree now has a unique key.

marshaling the tree is updated to cache the node at all given lines every
time write_tree is called.

marshaling a line is greatly simplified and just looks at the cached now
to understand which node is being selected.

closes #10

Signed-off-by: ldelossa <louis.delos@gmail.com>
ldelossa added a commit that referenced this issue Jul 22, 2022
after researching #10 a bit more I found that certain LSPs (gopls here)
provides more accurate symbol information via a workspace symbol query.

it would be nice to receieve the same symbol info regardless of the lsp
method being used. see: golang/go#49690

this pr now resolves the workspace symbol for all call hierarchy items
placed into the tree.

this is a bit slower (with gopls anyway) on start, however I've found
that after some caching the results are snappy.

Signed-off-by: ldelossa <louis.delos@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants