Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the ability to start a thread on the file not just the lines #92

Open
jemershaw opened this issue Oct 6, 2023 · 3 comments
Open

Comments

@jemershaw
Copy link
Contributor

the diffview does show the comment but it doesn't seem like the user can create a thread outside of the diff lines.

@ldelossa
Copy link
Owner

ldelossa commented Oct 7, 2023

Can you show me what you mean here in the Github UI?

Im not immediately seeing what you mean.

We can create comments on commits, but im unaware of a "file level" commit. Could be that ive just never done this.

@rmacklin
Copy link

rmacklin commented Oct 7, 2023

@roshaans
Copy link

I would love this feature as well. I have a set of diffs in a PR that I would like to comment and start a thread on, but I have to first find the specific commit that made the change in order to be able to comment anything and this is a big limitation imo.

It would be a simpler workflow to

  1. open the PR using gh.nvim,
  2. then go to any diff on any file, and be able to call GHCreateThread which then brings up a modal filled with commits that changed the specific file ( see advanced-git-search)
  3. write your thread comment on the split-screen buffer that opens up.
  4. submit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants