fix: fix review thread conflicts #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldelossa
force-pushed
the
fix-review-threads
branch
2 times, most recently
from
47f4140
to
a897796
Compare
previous to this commit gh.nvim did not understand that a comment can track its original commit sha without this, it could not decipher which comments belonged to which commits and would overrlay comments over multiple commits. with these changes will now only display comments on a commit in the commit tree view, checkout the commit and open the correct files when using the Conversations: tab, and correctly sync review threads to their commits during review. when HEAD is checked out all threads are displayed using their updated line numbers if the line was moved without change. when a specific commit is opened the original line numbers will be used which associate to the original line the comment was made on. additionally, a few UI elements have changed. the Conversations: tab in the pr details tree now shows the commit a threaded conversation belongs to. Also, an asterick is used in the Commits: tree now to indicate which commit gh.nvim has currently checked out. fixes: #47 Signed-off-by: Louis DeLosSantos <louis.delos@gmail.com>
ldelossa
force-pushed
the
fix-review-threads
branch
from
a897796
to
7b871f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous to this commit gh.nvim did not understand that a comment can
track its original commit sha
without this, it could not decipher which comments belonged to which
commits and would overrlay comments over multiple commits.
with these changes will now only display comments on a commit in the
commit tree view, checkout the commit and open the correct files when
using the Conversations: tab, and correctly sync review threads to their
commits during review.
additionally, a few UI elements have changed. the Conversations: tab in
the pr details tree now shows the commit a threaded conversation belongs
to. Also, an asterick is used in the Commits: tree now to indicate which
commit gh.nvim has currently checked out.
fixes: #47
Signed-off-by: Louis DeLosSantos louis.delos@gmail.com