Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When starting a review: creating a single line comment is broken #90

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

jemershaw
Copy link
Contributor

@jemershaw jemershaw commented Oct 6, 2023

This fixes the single line comment during a review. It seems like on 2023-10-01 GH deprecated the possiton and path which is what was used to create a comment during a started review. It seems like here states to use addPullRequestReviewThread instead.

This addresses #76 and possibly #86

Copy link
Owner

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks a lot

@ldelossa ldelossa merged commit a25fc74 into ldelossa:main Oct 6, 2023
@jemershaw jemershaw deleted the review-comment-broken branch October 6, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants