Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The SoundCloud shortcode should be using a button element instead of a div #33

Closed
ldeso opened this issue Dec 21, 2023 · 1 comment
Closed

The SoundCloud shortcode should be using a button element instead of a div #33

ldeso opened this issue Dec 21, 2023 · 1 comment

Comments

@ldeso
Copy link
Owner

ldeso commented Dec 21, 2023

A "<div>" element is used for the button that loads the SoundCloud player in the SoundCloud shortcode. A "<button>" element would be more appropriate.
ldeso added a commit that referenced this issue Dec 22, 2023
@ldeso
Use <button> element in SoundCloud shortcode (#33)
d4c383e
@ldeso
Copy link
Owner Author

ldeso commented Dec 28, 2023

Fixed in v1.0.1.

@ldeso ldeso closed this as completed Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ldeso