fix: read only STDOUT from "go list" #6
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, "go list -m -json", outputs valid JSON on STDOUT, but also other messages on STDERR, such as warnings. Restrict ourselves to just parsing the contents of STDOUT to avoid failures while unmarshalling.
As an example of this situation:
Running gomoddirectives under golanci-lint in this situation results in
without this PR, and a successful run of gomoddirectives with this PR.
Please let me know if you'd like a unit test written for this case. I haven't written one yet because it didn't seem to fit in to the general structure of the other unit tests that already exist.
Thank you very much for gomoddirectives and golangci-lint!