enhance coverage

ldez · Aug 15, 2014 · 370aadf · 370aadf
1 parent 4466e01
commit 370aadf
Show file tree

Hide file tree

Showing 8 changed files with 90 additions and 82 deletions.
diff --git a/maven-central-plugin/pom.xml b/maven-central-plugin/pom.xml
@@ -33,6 +33,13 @@
 			<artifactId>guava</artifactId>
 		</dependency>
 
+		<!-- ==== Logback ==== -->
+		<dependency>
+			<groupId>ch.qos.logback</groupId>
+			<artifactId>logback-classic</artifactId>
+			<scope>test</scope>
+		</dependency>
+
 		<!-- ===== jUnit ===== -->
 		<dependency>
 			<groupId>junit</groupId>

diff --git a/maven-central-plugin/src/main/java/org/maven/search/rest/model/Answer.java b/maven-central-plugin/src/main/java/org/maven/search/rest/model/Answer.java
@@ -1,5 +1,7 @@
 package org.maven.search.rest.model;
 
+import org.apache.commons.lang3.builder.ToStringBuilder;
+
 public class Answer {
 
     private ResponseHeader responseHeader;
@@ -24,13 +26,7 @@ public final void setResponse(final Response response) {
 
     @Override
     public final String toString() {
-        final StringBuilder builder = new StringBuilder();
-        builder.append("Answer [responseHeader=");
-        builder.append(this.responseHeader);
-        builder.append(", response=");
-        builder.append(this.response);
-        builder.append("]");
-        return builder.toString();
+        return ToStringBuilder.reflectionToString(this);
     }
 
 }
diff --git a/maven-central-plugin/src/main/java/org/maven/search/rest/model/Docs.java b/maven-central-plugin/src/main/java/org/maven/search/rest/model/Docs.java
@@ -2,6 +2,8 @@
 
 import java.util.List;
 
+import org.apache.commons.lang3.builder.ToStringBuilder;
+
 import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
 
 @JsonIgnoreProperties(ignoreUnknown = true)
@@ -73,23 +75,7 @@ public final void setEc(final List<String> ec) {
 
     @Override
     public final String toString() {
-        final StringBuilder builder = new StringBuilder();
-        builder.append("Docs [id=");
-        builder.append(this.id);
-        builder.append(", g=");
-        builder.append(this.g);
-        builder.append(", a=");
-        builder.append(this.a);
-        builder.append(", v=");
-        builder.append(this.v);
-        builder.append(", p=");
-        builder.append(this.p);
-        builder.append(", tags=");
-        builder.append(this.tags);
-        builder.append(", ec=");
-        builder.append(this.ec);
-        builder.append("]");
-        return builder.toString();
+        return ToStringBuilder.reflectionToString(this);
     }
 
 }
diff --git a/maven-central-plugin/src/main/java/org/maven/search/rest/model/Params.java b/maven-central-plugin/src/main/java/org/maven/search/rest/model/Params.java
@@ -1,5 +1,7 @@
 package org.maven.search.rest.model;
 
+import org.apache.commons.lang3.builder.ToStringBuilder;
+
 public class Params {
 
     private String fl;
@@ -68,23 +70,7 @@ public final void setVersion(final String version) {
 
     @Override
     public final String toString() {
-        final StringBuilder builder = new StringBuilder();
-        builder.append("Params [fl=");
-        builder.append(this.fl);
-        builder.append(", sort=");
-        builder.append(this.sort);
-        builder.append(", indent=");
-        builder.append(this.indent);
-        builder.append(", q=");
-        builder.append(this.q);
-        builder.append(", wt=");
-        builder.append(this.wt);
-        builder.append(", rows=");
-        builder.append(this.rows);
-        builder.append(", version=");
-        builder.append(this.version);
-        builder.append("]");
-        return builder.toString();
+        return ToStringBuilder.reflectionToString(this);
     }
 
 }
diff --git a/maven-central-plugin/src/main/java/org/maven/search/rest/model/Response.java b/maven-central-plugin/src/main/java/org/maven/search/rest/model/Response.java
@@ -2,6 +2,8 @@
 
 import java.util.List;
 
+import org.apache.commons.lang3.builder.ToStringBuilder;
+
 public class Response {
 
     private Long numFound;
@@ -36,15 +38,7 @@ public final void setDocs(final List<Docs> docs) {
 
     @Override
     public final String toString() {
-        final StringBuilder builder = new StringBuilder();
-        builder.append("Response [numFound=");
-        builder.append(this.numFound);
-        builder.append(", start=");
-        builder.append(this.start);
-        builder.append(", docs=");
-        builder.append(this.docs);
-        builder.append("]");
-        return builder.toString();
+        return ToStringBuilder.reflectionToString(this);
     }
 
 }
diff --git a/maven-central-plugin/src/main/java/org/maven/search/rest/model/ResponseHeader.java b/maven-central-plugin/src/main/java/org/maven/search/rest/model/ResponseHeader.java
@@ -1,5 +1,7 @@
 package org.maven.search.rest.model;
 
+import org.apache.commons.lang3.builder.ToStringBuilder;
+
 import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
 
 @JsonIgnoreProperties(ignoreUnknown = true)
@@ -29,13 +31,7 @@ public final void setParams(final Params params) {
 
     @Override
     public final String toString() {
-        final StringBuilder builder = new StringBuilder();
-        builder.append("ResponseHeader [status=");
-        builder.append(this.status);
-        builder.append(", params=");
-        builder.append(this.params);
-        builder.append("]");
-        return builder.toString();
+        return ToStringBuilder.reflectionToString(this);
     }
 
 }
diff --git a/maven-central-plugin/src/test/java/org/maven/search/rest/model/SimplePojoTest.java b/maven-central-plugin/src/test/java/org/maven/search/rest/model/SimplePojoTest.java
@@ -0,0 +1,65 @@
+package org.maven.search.rest.model;
+
+import java.util.List;
+
+import org.junit.Before;
+import org.junit.Test;
+
+import com.openpojo.reflection.PojoClass;
+import com.openpojo.reflection.PojoClassFilter;
+import com.openpojo.reflection.filters.FilterClassName;
+import com.openpojo.reflection.impl.PojoClassFactory;
+import com.openpojo.validation.PojoValidator;
+import com.openpojo.validation.affirm.Affirm;
+import com.openpojo.validation.rule.impl.GetterMustExistRule;
+import com.openpojo.validation.rule.impl.NoPublicFieldsRule;
+import com.openpojo.validation.rule.impl.NoStaticExceptFinalRule;
+import com.openpojo.validation.rule.impl.SerializableMustHaveSerialVersionUIDRule;
+import com.openpojo.validation.rule.impl.SetterMustExistRule;
+import com.openpojo.validation.test.impl.DefaultValuesNullTester;
+import com.openpojo.validation.test.impl.GetterTester;
+import com.openpojo.validation.test.impl.SetterTester;
+
+public class SimplePojoTest {
+
+    private static final int EXPECTED_CLASS_COUNT = 5;
+
+    private List<PojoClass> pojoClasses;
+
+    private PojoValidator pojoValidator;
+
+    @Before
+    public void setup() {
+        // The package to test
+        final String packageName = Answer.class.getPackage().getName();
+        final PojoClassFilter filter = new FilterClassName("^((?!Test$).)*$");
+        this.pojoClasses = PojoClassFactory.getPojoClasses(packageName, filter);
+
+        this.pojoValidator = new PojoValidator();
+
+        // Create Rules to validate structure for POJO_PACKAGE
+        this.pojoValidator.addRule(new NoPublicFieldsRule());
+        this.pojoValidator.addRule(new NoStaticExceptFinalRule());
+        this.pojoValidator.addRule(new GetterMustExistRule());
+        this.pojoValidator.addRule(new SetterMustExistRule());
+        this.pojoValidator.addRule(new SerializableMustHaveSerialVersionUIDRule());
+
+        // Create Testers to validate behaviour for POJO_PACKAGE
+        this.pojoValidator.addTester(new DefaultValuesNullTester());
+        this.pojoValidator.addTester(new SetterTester());
+        this.pojoValidator.addTester(new GetterTester());
+    }
+
+    @Test
+    public void ensureExpectedPojoCount() {
+        Affirm.affirmEquals("Classes added / removed?", EXPECTED_CLASS_COUNT, this.pojoClasses.size());
+    }
+
+    @Test
+    public void testPojoStructureAndBehavior() {
+        for (final PojoClass pojoClass : this.pojoClasses) {
+            this.pojoValidator.runValidation(pojoClass);
+        }
+    }
+
+}
diff --git a/nexus-plugin/src/main/java/org/sonatype/nexus/json/Answer.java b/nexus-plugin/src/main/java/org/sonatype/nexus/json/Answer.java
@@ -1,5 +1,7 @@
 package org.sonatype.nexus.json;
 
+import org.apache.commons.lang3.builder.ToStringBuilder;
+
 public class Answer {
 
     private String resourceURI;
@@ -104,31 +106,7 @@ public final void setArtifactLink(final String artifactLink) {
 
     @Override
     public final String toString() {
-        final StringBuilder builder = new StringBuilder();
-        builder.append("Answer [resourceURI=");
-        builder.append(this.resourceURI);
-        builder.append(", groupId=");
-        builder.append(this.groupId);
-        builder.append(", artifactId=");
-        builder.append(this.artifactId);
-        builder.append(", version=");
-        builder.append(this.version);
-        builder.append(", classifier=");
-        builder.append(this.classifier);
-        builder.append(", packaging=");
-        builder.append(this.packaging);
-        builder.append(", extension=");
-        builder.append(this.extension);
-        builder.append(", repoId=");
-        builder.append(this.repoId);
-        builder.append(", contextId=");
-        builder.append(this.contextId);
-        builder.append(", pomLink=");
-        builder.append(this.pomLink);
-        builder.append(", artifactLink=");
-        builder.append(this.artifactLink);
-        builder.append("]");
-        return builder.toString();
+        return ToStringBuilder.reflectionToString(this);
     }
 
 }