Skip to content

Commit

Permalink
Fixed and simplified the unit test
Browse files Browse the repository at this point in the history
  • Loading branch information
Dong Hun Lee committed Apr 2, 2024
1 parent 3911681 commit 879ca05
Showing 1 changed file with 14 additions and 18 deletions.
32 changes: 14 additions & 18 deletions core/unit_test/TestMDRangePolicyConstructors.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -158,25 +158,21 @@ TEST(TEST_CATEGORY, policy_get_tile_size) {
policy.tile_size_max_total());

for (std::size_t i = 0; i < rank; ++i) {
#if defined(KOKKOS_ENABLE_CUDA) || defined(KOKKOS_ENABLE_HIP) || \
defined(KOKKOS_ENABLE_SYCL)
EXPECT_EQ(default_size_properties.default_largest_tile_size,
policy.tile_size_max_recommended_per_rank(i));
if (i == last_rank) {
if (default_size_properties.default_largest_tile_size == 0)
EXPECT_EQ(100, rec_tile_size[i]);
else
EXPECT_EQ(default_size_properties.default_largest_tile_size,
rec_tile_size[i]);
if (default_size_properties.default_largest_tile_size == 0) {
EXPECT_EQ(100, policy.tile_size_max_recommended_per_rank(i));

auto expected_rec_tile_size =
(i == last_rank) ? 100 : default_size_properties.default_tile_size;
EXPECT_EQ(expected_rec_tile_size, rec_tile_size[i]);
} else {
EXPECT_EQ(default_size_properties.default_largest_tile_size,
policy.tile_size_max_recommended_per_rank(i));

auto expected_rec_tile_size =
(i == last_rank) ? default_size_properties.default_largest_tile_size
: default_size_properties.default_tile_size;
EXPECT_EQ(expected_rec_tile_size, rec_tile_size[i]);
}
#else
EXPECT_EQ(100, policy.tile_size_max_recommended_per_rank(i));
if (i == last_rank)
EXPECT_EQ(policy.tile_size_max_recommended_per_rank(last_rank),
rec_tile_size[i]);
#endif
else
EXPECT_EQ(default_size_properties.default_tile_size, rec_tile_size[i]);
}
}
}
Expand Down

0 comments on commit 879ca05

Please sign in to comment.