Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new UI style, animation on controls, fullscreen callback and title on video --WIP-- #26

Closed
wants to merge 22 commits into from
Closed

new UI style, animation on controls, fullscreen callback and title on video --WIP-- #26

wants to merge 22 commits into from

Conversation

Liroo
Copy link

@Liroo Liroo commented Aug 26, 2016 •
edited
Loading

Hey, I use this package to implement videoview inside our app but there are many gaps that PR can fill.

I reviewed the interface to make it more attractive and easier. So I added cool animations
I added a title to the video might appear at the top of the view at the same time as controls.
I tried to Implement a full-screen mode but I have not succeeded without adding too many dependencies, and our applications we will manage with Navigation. so I just add a callback and a fullscreen button.

Poster is now press able to start video.

  • UI controls style
  • UI Animations (mount/unmount)
  • UI Animation (controls disappears after short timing)
  • UI title style
  • added 'flow' on project (not locally implemented)
  • FullScreen mode (at this time callback is called but you should handle this in you own app... In our own app we use react-native-orientation and the experimental navigation from react-native)
  • ReadMe update
  • Review of Demo then add a gif to README with new Demo
  • update Slider where you could hit the slider anywhere (PR must be on dependencie, not on this repo)

testauthbasic and others added 5 commits August 25, 2016 09:47
@testauthbasic
Updated both package.json (module and Demo) to link to the right Azen…
4b95c0c 
…doo package
@testauthbasic
Updated both package.json (module and Demo) to link to the right Azen…
6fabd5e 
…doo package
@testauthbasic
Many features... new UI with animations and capacity of fullscreen (f…
7b8e5ae 
…ullscreen view is not handle, only rotation of the screen is handled, there is a callback where you should update the view to fullscreen when you press the button), refactoring of the code and new style. title added to the props for next update. Demo updated
@Liroo
Update README.md
28dfa09
@testauthbasic
Added short timing (2.5s) on appear and disapear of controls and a ti…
65f1c44 
…tle on video, title is shown only if props title is defined, review of icons design
@Liroo Liroo changed the title new UI style, animation on controls, fullscreen* and title on video* (* WIP) new UI style, animation on controls, fullscreen* and title on video (* WIP) Aug 30, 2016
Liroo and others added 2 commits August 30, 2016 12:02
@Liroo
Update Controls.js
a129630 
Remove test dependencies
@testauthbasic
Add fullscreenEnable props which add or remove the button fullscreen,…
39e00e4 
… remove Orientation package from dependencies, fix style on controls/poster, add props to handle timer of controls
@Liroo Liroo changed the title new UI style, animation on controls, fullscreen* and title on video (* WIP) new UI style, animation on controls, fullscreen callback and title on video Aug 30, 2016
@Liroo Liroo changed the title new UI style, animation on controls, fullscreen callback and title on video new UI style, animation on controls, fullscreen callback and title on video --WIP-- Aug 30, 2016
@Liroo Liroo mentioned this pull request Aug 31, 2016
Open
@Liroo
Copy link
Author

Liroo commented Aug 31, 2016 •
edited
Loading

FullScreen is implemented with Navigator (only view is implemented, not actually seekTo, correct animations, etc...)

EDIT: just see I have to set fullscreen icon controlled

@Liroo
Copy link
Author

Liroo commented Sep 1, 2016

Check this PR @ldn0x7dc

@Liroo
Copy link
Author

Liroo commented Sep 2, 2016

Didn't add a gif to README, I don't have enough time :/ My last commit is about how to handle fullscreen in JS with Navigator, there's some bugs but I have to work on another project, please comment this PR if you want to discuss 🍖 😸

@kingctan
Copy link

kingctan commented Oct 25, 2016 •
edited
Loading

how to pause? trouble with this. please help,thanks.
and when switch to fullscreen, 2 videos, and 2 audios,
and navigator back to exit, this will always be playing background.

@Liroo
Copy link
Author

Liroo commented Nov 3, 2016

That was a tentative to play video in full screen but there is definitively not possible without changing the native module... Or getting a native view which can expand (or js view at root).
I close this PR w/o answer of the owner of the repo....

@Liroo Liroo closed this Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Liroo @kingctan @testauthbasic