Minor update for UnLynx v1.4.1

[JoaoAndreSa]

A series of commits to make medco-unlynx on par with the new unlynx v1.4.1 and onet 3.2.0:

Similar changes as https://github.com/ldsec/unlynx/releases/tag/v1.4.1

Out of topic question
For these kind of minor changes do I still do a PR to dev (and then later move to master) or should I just commit directly to dev? It's not that I'm actually developing a new feature or something :P

[mickmis]

IMO small developments/changes like this can go directly to dev. For :

• larger features
• refactoring
• something else that require more than one person development
• something else that require review from someone else

should have its own separate branch.

We should also maybe introduce the concept of code owners in our workflow.

Whatever we agree on (including @f-marino ), this should go in the guidelines :)

Thoughts?

[mickmis]

Looks all good, but something important should be added (and it's not valid just for your changes, but also other things we did before), all the configuration variables should be documented in e.g. the README.md.

Also the CONN_TIMEMOUT should be added into the deployment/Dockerfile + deployment/docker-compose.yml for reference.

[f-marino]

I am working to embed the comments I received on the guidelines from Linus, which actually touch also this topic. I will tell you when I am done, so that you can check it and make sure that both of you are satisfied with the final result.

[JoaoAndreSa]

Looks all good, but something important should be added (and it's not valid just for your changes, but also other things we did before), all the configuration variables should be documented in e.g. the README.md.

Also the CONN_TIMEMOUT should be added into the deployment/Dockerfile + deployment/docker-compose.yml for reference.

done 0a3b954

As for the README I am currently exporting unlynx updated documentation to gitbooks (which will include a list of env variables that you can set). For the medco-unlynx do you have any suggestions on where should I add this info, maybe medco-documentation/system-administrators/deployment/configuration?

[JoaoAndreSa]

@mickmis can I merge this? I think the only thing left is adding the configuration variables to the documentation. I have them in the unlynx README, but I wonder if we should add it someplace else...