Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Reduce the number of guard towers required for Happiness #985

Closed
Amadeus99 opened this issue May 14, 2017 · 10 comments
Closed

Request: Reduce the number of guard towers required for Happiness #985

Amadeus99 opened this issue May 14, 2017 · 10 comments
Assignees
Labels
Question This issue pertains to a question about the mod

Comments

@Amadeus99
Copy link

Minecolonies version

Curse 0.8.1009

Expected behavior

Not to need almost half your population as Guards.

Actual behaviour

With this update, housing has some affect on happiness. I believe at most, averageHousing would be equal to 5 which is only as valuable as one level 5 Guard Tower. Saturation looks like it would max out to be as valuable as one level 5 Guard Tower, as well. So, best case you could have two less Guard Towers and break even. This is all assuming you max out all building levels. If you have 10 level 5 houses, you would be able to have 26 citizens assigned to max level work buildings and would have to have 24 citizens as Guards. And that would only allow you to break even on Happiness IF you got the best value for Saturation every day. So, more than likely you would have to have 25 Guards. It just seems a bit much to me to have to have half your population as Guards in order to keep your colony happy.

If needing half your population as Guards was intended, then please just close this ticket. If not, maybe do something as simple as doubling the worth of Guard Tower levels which would drop the number of Guard Towers needed to one third the colony population. Or triple the worth of Guard Tower levels to reduce needed Guard Towers to one quarter the population.
Thanks.

@nekatu
Copy link

nekatu commented May 14, 2017

I have to agree with this, as per #979; this requirement for 1 guard tower per worker hut seems excessive.

A better system might be 1 guard tower per citizen house instead, that way you have a 1 tower to 5 citizen ratio, which seems fair to me. Especially given that all citizens are in the houses (or the hall) at night, which is generally the time they would by most scared and in need of protection.

You could even have it so that the higher level towers support 2 guards (as per the number of beds) which means you should need half the number of towers currently required anyway.

@marvin-bitterlich marvin-bitterlich added the Question This issue pertains to a question about the mod label May 14, 2017
@Raycoms
Copy link
Contributor

Raycoms commented May 14, 2017 via email

@Raycoms
Copy link
Contributor

Raycoms commented May 14, 2017 via email

@Amadeus99
Copy link
Author

So, based on your example, 15 citizens. 3 level 5 houses would make averageHousing = 5. Happiness increases by 5 * HAPPINESS_FACTOR which is 0.1 which means happiness increases by 0.5.

I am assuming saturation maxes out at 10. Maximum averageSaturation would be 10. WELL_SATURATED_LIMIT = 5. That means maximum increase to happiness would be (averageSaturation - WELL_SATURATED_LIMIT) * HAPPINESS_FACTOR = (10 - 5) * 0.1 = 0.5.

10 workers working in level 5 buildings: requiredGuardLevels += 50. 5 guards in level 5 towers: requiredGuardLevels -= 25. requiredGuardLevels = 25. Happiness decreases by 25 * HAPPINESS_FACTOR = 2.5.

Overall happiness decreases by 1.5.

Changing to 9 workers and 6 guards would be a decrease in happiness by 0.5. And changing to 8 workers and 7 guards would be an increase to happiness by 0.5. So, back to nearly half the population as guards.

Where am I going wrong with the calculations?

@Raycoms
Copy link
Contributor

Raycoms commented May 14, 2017 via email

@SulpherStaer
Copy link

How many workers do you all add in your colony? You don't need that many. One or two is more than enough! Unless you feel they are building WAY to slow?...

@Amadeus99
Copy link
Author

I'm guessing you mean specifically builders which we have 2. Overall for workers, we have 2 builders, 2 delivermen, 2 miners, 1 farmer, and 1 lumberjack.

@Amadeus99
Copy link
Author

I just looked at the changes to how happiness is modified based on guard tower levels. Please correct me if I'm wrong, but:

  1. Now you lose happiness if you have more guard tower levels than worker building levels if you have at least twice as many guard tower levels as worker building levels.
  2. You can have no guard towers and you will have no loss in happiness.
  3. You can no longer gain happiness from having any amount of guard towers.

@Raycoms
Copy link
Contributor

Raycoms commented May 16, 2017 via email

@Raycoms
Copy link
Contributor

Raycoms commented May 22, 2017

That should be fixed already.

@Raycoms Raycoms closed this as completed May 22, 2017
@ghost ghost removed the In Progress label May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Question This issue pertains to a question about the mod
Projects
None yet
Development

No branches or pull requests

5 participants