Feature/pvp system #2723
Merged
Feature/pvp system #2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add configuration - Add list of attacking players with guard - Turn off anti griefing if player has guards with him - Increase durability of colony blocks - Delete colony on townhall destroyed.
and improve with the use of constants the readability
LDTTeam-Buildsystem
previously approved these changes
Aug 1, 2018
marchermans
previously approved these changes
Aug 2, 2018
| @@ -66,7 +67,7 @@ private void initBlock() | |||
| //Blast resistance for creepers etc. makes them explosion proof | |||
| setResistance(RESISTANCE); | |||
| //Hardness of 10 takes a long time to mine to not loose progress | |||
| setHardness(HARDNESS); | |||
| setHardness(Configurations.gameplay.pvp_mode ? HARDNESS * 2 : HARDNESS); | |||
There was a problem hiding this comment.
Bumb this factor to 4. It should be a challenge.
| import net.minecraft.potion.PotionEffect; | ||
| import net.minecraft.world.World; | ||
| import org.jetbrains.annotations.NotNull; | ||
|
|
||
| import java.util.stream.Stream; | ||
|
|
||
| import static com.minecolonies.api.util.constant.Constants.*; | ||
|
|
||
| /** | ||
| * Class handling the Chief Sword item. | ||
| */ | ||
| public class ItemChiefSword extends ItemSword |
There was a problem hiding this comment.
Maybe buff the ChiefSword in PVP Mode?
There was a problem hiding this comment.
Nah, it's quite rare and it's less op than most tinkers swords as well, so I don't see much of an issue with it.
LDTTeam-Buildsystem
dismissed
their stale review
A new analysis is being ran. Please wait for the results.
LDTTeam-Buildsystem
previously approved these changes
Aug 2, 2018
LDTTeam-Buildsystem
previously approved these changes
Aug 2, 2018
LDTTeam-Buildsystem
previously approved these changes
Aug 2, 2018
LDTTeam-Buildsystem
dismissed
their stale review
A new analysis is being ran. Please wait for the results.
LDTTeam-Buildsystem
previously approved these changes
Aug 2, 2018
LDTTeam-Buildsystem
previously approved these changes
Aug 2, 2018
LDTTeam-Buildsystem
dismissed stale reviews from themself
A new analysis is being ran. Please wait for the results.
LDTTeam-Buildsystem
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the first part of complete PVP system.
This contains:
Changes proposed in this pull request:
Review please