-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/pvp system #2723
Feature/pvp system #2723
Conversation
- Add configuration - Add list of attacking players with guard - Turn off anti griefing if player has guards with him - Increase durability of colony blocks - Delete colony on townhall destroyed.
and improve with the use of constants the readability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Analysis Complete
Statistics:
Count | New | Old | Diff | |
---|---|---|---|---|
Total | 0 | 0 | 0 | 0 |
Errors | 0 | 0 | 0 | 0 |
More Information:
@@ -66,7 +67,7 @@ private void initBlock() | |||
//Blast resistance for creepers etc. makes them explosion proof | |||
setResistance(RESISTANCE); | |||
//Hardness of 10 takes a long time to mine to not loose progress | |||
setHardness(HARDNESS); | |||
setHardness(Configurations.gameplay.pvp_mode ? HARDNESS * 2 : HARDNESS); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumb this factor to 4. It should be a challenge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea
import net.minecraft.potion.PotionEffect; | ||
import net.minecraft.world.World; | ||
import org.jetbrains.annotations.NotNull; | ||
|
||
import java.util.stream.Stream; | ||
|
||
import static com.minecolonies.api.util.constant.Constants.*; | ||
|
||
/** | ||
* Class handling the Chief Sword item. | ||
*/ | ||
public class ItemChiefSword extends ItemSword |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe buff the ChiefSword in PVP Mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, it's quite rare and it's less op than most tinkers swords as well, so I don't see much of an issue with it.
A new analysis is being ran. Please wait for the results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Analysis Complete
Statistics:
Count | New | Old | Diff | |
---|---|---|---|---|
Total | 0 | 0 | 0 | 0 |
Errors | 0 | 0 | 0 | 0 |
More Information:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Analysis Complete
Statistics:
Count | New | Old | Diff | |
---|---|---|---|---|
Total | 0 | 0 | 0 | 0 |
Errors | 0 | 0 | 0 | 0 |
More Information:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Analysis Complete
Statistics:
Count | New | Old | Diff | |
---|---|---|---|---|
Total | 0 | 0 | 0 | 0 |
Errors | 0 | 0 | 0 | 0 |
More Information:
A new analysis is being ran. Please wait for the results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Analysis Complete
Statistics:
Count | New | Old | Diff | |
---|---|---|---|---|
Total | 0 | 0 | 0 | 0 |
Errors | 0 | 0 | 0 | 0 |
More Information:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Analysis Complete
Statistics:
Count | New | Old | Diff | |
---|---|---|---|---|
Total | 0 | 0 | 0 | 0 |
Errors | 0 | 0 | 0 | 0 |
More Information:
A new analysis is being ran. Please wait for the results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Analysis Complete
Statistics:
Count | New | Old | Diff | |
---|---|---|---|---|
Total | 0 | 0 | 0 | 0 |
Errors | 0 | 0 | 0 | 0 |
Adds the first part of complete PVP system.
This contains:
Changes proposed in this pull request:
Review please