Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make barbarians place ladders and break walls #2856

Merged
merged 12 commits into from
Sep 10, 2018
Merged

Make barbarians place ladders and break walls #2856

merged 12 commits into from
Sep 10, 2018

Conversation

Raycoms
Copy link
Contributor

@Raycoms Raycoms commented Sep 6, 2018

Changes proposed in this pull request:

  • Makes barbarians more intelligent and have them build ladders and break blocks

Review please

LDTTeam-Buildsystem
LDTTeam-Buildsystem previously approved these changes Sep 6, 2018
View reviewed changes
Copy link
Collaborator

@LDTTeam-Buildsystem LDTTeam-Buildsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analysis Complete

Statistics:
Count New Old Diff
Total 0 0 0 0
Errors 0 0 0 0
More Information:

@ldtteam ldtteam deleted a comment Sep 6, 2018
@ldtteam ldtteam deleted a comment Sep 6, 2018
@ldtteam ldtteam deleted a comment Sep 6, 2018
@ldtteam ldtteam deleted a comment Sep 6, 2018
@ldtteam ldtteam deleted a comment Sep 6, 2018
@ldtteam ldtteam deleted a comment Sep 6, 2018
@ldtteam ldtteam deleted a comment Sep 6, 2018
@ldtteam ldtteam deleted a comment Sep 6, 2018
@ldtteam ldtteam deleted a comment Sep 6, 2018
@ldtteam ldtteam deleted a comment Sep 6, 2018
LDTTeam-Buildsystem
LDTTeam-Buildsystem previously approved these changes Sep 6, 2018
View reviewed changes
Copy link
Collaborator

@LDTTeam-Buildsystem LDTTeam-Buildsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analysis Complete

Statistics:
Count New Old Diff
Total 0 0 0 0
Errors 0 0 0 0
More Information:

LDTTeam-Buildsystem
LDTTeam-Buildsystem previously approved these changes Sep 6, 2018
View reviewed changes
Copy link
Collaborator

@LDTTeam-Buildsystem LDTTeam-Buildsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analysis Complete

Statistics:
Count New Old Diff
Total 0 0 0 0
Errors 0 0 0 0
More Information:

marchermans
marchermans previously requested changes Sep 6, 2018
View reviewed changes
Copy link
Contributor

@marchermans marchermans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question regarding the navigator field and the logging needs to be gone.

src/main/java/com/minecolonies/coremod/entity/ai/mobs/barbarians/AbstractEntityBarbarian.java Outdated
*/
private synchronized void updateNavigatorField()
{
if (navigatorField == null)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this done here instead of using an AT?

src/main/java/com/minecolonies/coremod/entity/ai/mobs/barbarians/EntityAIWalkToRandomHuts.java Outdated
entity.getNavigator().clearPath();
stuckTime = 0;
entity.setStuckCounter(entity.getStuckCounter() + 1);
Log.getLogger().warn("runnin");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the logging.

src/main/java/com/minecolonies/coremod/entity/ai/mobs/barbarians/EntityAIWalkToRandomHuts.java Outdated
{
entity.setStuckCounter(0);
entity.setLadderCounter(entity.getLadderCounter()+1);
Log.getLogger().warn("ladders");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the logging.

@LDTTeam-Buildsystem LDTTeam-Buildsystem dismissed their stale review September 6, 2018 14:32

A new analysis is being ran. Please wait for the results.

LDTTeam-Buildsystem
LDTTeam-Buildsystem previously approved these changes Sep 6, 2018
View reviewed changes
Copy link
Collaborator

@LDTTeam-Buildsystem LDTTeam-Buildsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analysis Complete

Statistics:
Count New Old Diff
Total 0 0 0 0
Errors 0 0 0 0
More Information:

@ldtteam ldtteam deleted a comment Sep 6, 2018
@ldtteam ldtteam deleted a comment Sep 6, 2018
@ldtteam ldtteam deleted a comment Sep 6, 2018
@ldtteam ldtteam deleted a comment Sep 6, 2018
LDTTeam-Buildsystem
LDTTeam-Buildsystem previously approved these changes Sep 6, 2018
View reviewed changes
Copy link
Collaborator

@LDTTeam-Buildsystem LDTTeam-Buildsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analysis Complete

Statistics:
Count New Old Diff
Total 0 0 0 0
Errors 0 0 0 0
More Information:

LDTTeam-Buildsystem
LDTTeam-Buildsystem previously approved these changes Sep 7, 2018
View reviewed changes
Copy link
Collaborator

@LDTTeam-Buildsystem LDTTeam-Buildsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analysis Complete

Statistics
Count New Old Diff
Total 744 0 0 0
Errors 70 0 0 0

marchermans
marchermans previously approved these changes Sep 8, 2018
View reviewed changes
@LDTTeam-Buildsystem LDTTeam-Buildsystem dismissed their stale review September 8, 2018 16:55

A new analysis is being ran. Please wait for the results.

LDTTeam-Buildsystem
LDTTeam-Buildsystem previously approved these changes Sep 8, 2018
View reviewed changes
Copy link
Collaborator

@LDTTeam-Buildsystem LDTTeam-Buildsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analysis Complete

Statistics:
Count New Old Diff
Total 0 0 0 0
Errors 0 0 0 0
More Information:

@ldtteam ldtteam deleted a comment Sep 8, 2018
@ldtteam ldtteam deleted a comment Sep 8, 2018
LDTTeam-Buildsystem
LDTTeam-Buildsystem previously approved these changes Sep 8, 2018
View reviewed changes
Copy link
Collaborator

@LDTTeam-Buildsystem LDTTeam-Buildsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analysis Complete

Statistics:
Count New Old Diff
Total 0 0 0 0
Errors 0 0 0 0
More Information:

@LDTTeam-Buildsystem LDTTeam-Buildsystem dismissed their stale review September 8, 2018 19:53

A new analysis is being ran. Please wait for the results.

@ldtteam ldtteam deleted a comment Sep 8, 2018
LDTTeam-Buildsystem
LDTTeam-Buildsystem previously approved these changes Sep 8, 2018
View reviewed changes
Copy link
Collaborator

@LDTTeam-Buildsystem LDTTeam-Buildsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analysis Complete

Statistics:
Count New Old Diff
Total 0 0 0 0
Errors 0 0 0 0
More Information:

@ldtteam ldtteam deleted a comment Sep 9, 2018
@ldtteam ldtteam deleted a comment Sep 9, 2018
LDTTeam-Buildsystem
LDTTeam-Buildsystem previously approved these changes Sep 9, 2018
View reviewed changes
Copy link
Collaborator

@LDTTeam-Buildsystem LDTTeam-Buildsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analysis Complete

Statistics:
Count New Old Diff
Total 0 0 0 0
Errors 0 0 0 0
More Information:

LDTTeam-Buildsystem
LDTTeam-Buildsystem previously approved these changes Sep 9, 2018
View reviewed changes
Copy link
Collaborator

@LDTTeam-Buildsystem LDTTeam-Buildsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analysis Complete

Statistics:
Count New Old Diff
Total 0 0 0 0
Errors 0 0 0 0
More Information:

LDTTeam-Buildsystem
LDTTeam-Buildsystem previously approved these changes Sep 9, 2018
View reviewed changes
Copy link
Collaborator

@LDTTeam-Buildsystem LDTTeam-Buildsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analysis Complete

Statistics
Count New Old Diff
Total 744 0 0 0
Errors 70 0 0 0

@Raycoms Raycoms added the ready label Sep 9, 2018
@LDTTeam-Buildsystem LDTTeam-Buildsystem dismissed stale reviews from themself September 9, 2018 21:40

A new analysis is being ran. Please wait for the results.

LDTTeam-Buildsystem
LDTTeam-Buildsystem approved these changes Sep 9, 2018
View reviewed changes
Copy link
Collaborator

@LDTTeam-Buildsystem LDTTeam-Buildsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analysis Complete

Statistics:
Count New Old Diff
Total 0 0 0 0
Errors 0 0 0 0
More Information:

@Raycoms Raycoms merged commit 31c61e9 into version/1.12 Sep 10, 2018
@Raycoms Raycoms deleted the feature/nasty-barbs branch September 10, 2018 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchermans marchermans marchermans approved these changes

@LDTTeam-Buildsystem LDTTeam-Buildsystem LDTTeam-Buildsystem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Raycoms @marchermans @LDTTeam-Buildsystem