Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/stone smelter #3264

Merged
merged 10 commits into from
Jan 14, 2019
Merged

Feature/stone smelter #3264

merged 10 commits into from
Jan 14, 2019

Conversation

Raycoms
Copy link
Contributor

@Raycoms Raycoms commented Jan 13, 2019

Closes #3261

Changes proposed in this pull request:

  • Adds a stonesmeltery
  • Adds abstraction layer for any request smelter who still wants to solve normal requests as well
  • Adds a fix where on firing a worker all his requests would get canceled.
  • Fix to break larger requests of postbox into several requests

Review please

@ldtteam ldtteam deleted a comment Jan 13, 2019
@ldtteam ldtteam deleted a comment Jan 13, 2019
@ldtteam ldtteam deleted a comment Jan 13, 2019
@ldtteam ldtteam deleted a comment Jan 13, 2019
@ldtteam ldtteam deleted a comment Jan 13, 2019
@ldtteam ldtteam deleted a comment Jan 13, 2019
@ldtteam ldtteam deleted a comment Jan 13, 2019
@ldtteam ldtteam deleted a comment Jan 13, 2019
@ldtteam ldtteam deleted a comment Jan 13, 2019
@ldtteam ldtteam deleted a comment Jan 13, 2019
@ldtteam ldtteam deleted a comment Jan 13, 2019
@ldtteam ldtteam deleted a comment Jan 13, 2019
marchermans
marchermans previously approved these changes Jan 13, 2019
@ldtteam ldtteam deleted a comment Jan 13, 2019
@ldtteam ldtteam deleted a comment Jan 13, 2019
@ldtteam ldtteam deleted a comment Jan 13, 2019
@ldtteam ldtteam deleted a comment Jan 13, 2019
@ldtteam ldtteam deleted a comment Jan 13, 2019
@ldtteam ldtteam deleted a comment Jan 13, 2019
someaddons
someaddons previously approved these changes Jan 14, 2019
Copy link
Contributor

@someaddons someaddons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

someaddons
someaddons previously approved these changes Jan 14, 2019
@ldtteam ldtteam deleted a comment Jan 14, 2019
@ldtteam ldtteam deleted a comment Jan 14, 2019
@ldtteam ldtteam deleted a comment Jan 14, 2019
@ldtteam ldtteam deleted a comment Jan 14, 2019
@ldtteam ldtteam deleted a comment Jan 14, 2019
@ldtteam ldtteam deleted a comment Jan 14, 2019
@Raycoms Raycoms merged commit 99d7f35 into version/1.12 Jan 14, 2019
@Raycoms Raycoms deleted the feature/stone-smelter branch January 14, 2019 15:58
@ldtteam ldtteam deleted a comment Feb 11, 2019
@ldtteam ldtteam deleted a comment Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library workers not transitioning cleanly to other jobs
3 participants