Deco block #3511
Merged
Deco block #3511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raycoms
commented
Mar 24, 2019
| @@ -239,6 +240,7 @@ public static AbstractBuilding create(final Colony colony, @NotNull final TileEn | |||
|
|
|||
| if (building != null && parent.getWorld() != null && !(building instanceof PostBox)) | |||
| { | |||
| building.setRotation(BlockUtils.getRotationFromFacing(parent.getWorld().getBlockState(parent.getPosition()).getValue(AbstractBlockHut.FACING))); | |||
There was a problem hiding this comment.
This here is the default rotation, for when placed by hand, the real rotation is set later then, if existent
Nightenom
reviewed
Mar 24, 2019
| /** | ||
| * If the player opening the GUI is an admin. | ||
| */ | ||
| private boolean admin = Minecraft.getMinecraft().player.isCreative(); |
There was a problem hiding this comment.
maybe a better variable name?
since admin does not equal to creative imho
|
why does the window have no view?
|
marchermans
previously approved these changes
Mar 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #332
Closes #3508
Closes #3507
Changes proposed in this pull request:
Review please