Add mud bricks to paths and sanity-fix the dyer #9894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raycoms
previously approved these changes
Apr 6, 2024
|
while on this we probably should also add the missing cracked variants for e.g. stone brick |
uecasm
force-pushed
the
fix/muddy-paths-120
branch
from
9aeaf00
to
513cf66
Compare
Raycoms
reviewed
Jul 27, 2024
| @@ -28,6 +28,9 @@ | |||
| "minecraft:chiseled_nether_bricks", | |||
| "minecraft:gravel", | |||
| "minecraft:dirt_path", | |||
| "minecraft:mud_bricks", | |||
There was a problem hiding this comment.
Can you already add the missing strong brick, stone brick stairs, cracked etc?
There was a problem hiding this comment.
Cracked stone bricks are already in there via the STONE_BRICKS tag.
There was a problem hiding this comment.
I've added a path tag audit now, which makes it easier to see which blocks are paths and which aren't.
uecasm
changed the title
Raycoms
approved these changes
Jul 28, 2024
someaddons
approved these changes
Jul 28, 2024
Raycoms
added a commit
that referenced
this pull request
Aug 4, 2024
Port Add mud bricks to paths #9288 Move a bunch of DO ingredients from mechanic to sawmill or stonemason, to be more consistent with regular recipes. Fix mechanic sometimes duplicating DO ingredients handled by other crafters. Teach the dyer to obey guild rules Remove various duplicated crafting items already handled by other crafters (e.g. beds from wool, glass panes from glass). They can still craft those items, but only with the recipes that use dye. Allow postbox requests for dyed leather armor (if you have an example in your inventory). Show example dyed leather armor in the dyer's JEI info. image Add path block auditor. (This was already visible in the block tags audit, but it's easier to read this way.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes discord request
Closes discord request
Closes discord request
Changes proposed in this pull request:
[x] Yes I tested this before submitting it.
[ ] I also did a multiplayer test.
Review please