allow explicitly picking the xtables version #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldx
requested changes
Jan 31, 2018
iptc/xtables.py
Outdated
| _searchlib = "libxtables.so.%s" % (xtables_version,) | ||
| else: | ||
| _searchlib = "xtables" | ||
| print(_searchlib) |
There was a problem hiding this comment.
Can you remove this print statement? I assume it's only there for debugging purposes.
There was a problem hiding this comment.
Ah, indeed. Fixed now.
If I have multiple libxtable v 80ersions, I might want python-iptables to use a version that doesn't come from the libxtables.so symlink. Add a PYTHON_IPTABLES_XTABLES_VERSION that facilitates this. For example, $ IPTABLES_LIBDIR=/usr/lib/x86_64-linux-gnu/ PYTHON_IPTABLES_XTABLES_VERSION=11 somecommand.py uses version 11 of xtables.
benjaminp
force-pushed
the
xtables-version-by-env
branch
from
52247b9
to
d4537ea
Compare
ldx
approved these changes
Feb 1, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I have multiple libxtable versions, I might want python-iptables to use a
version that doesn't come from the libxtables.so symlink. Add a
PYTHON_IPTABLES_XTABLES_VERSION that facilitates this.
For example,
$ IPTABLES_LIBDIR=/usr/lib/x86_64-linux-gnu/ PYTHON_IPTABLES_XTABLES_VERSION=11 somecommand.py
uses version 11 of xtables.