Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper error import & lib autodetection #234

Merged
merged 3 commits into from
Apr 3, 2018
Merged

Proper error import & lib autodetection #234

merged 3 commits into from
Apr 3, 2018

Conversation

vintozver
Copy link
Contributor

Move errors out to the separate module to be able to catch the import level errors

Autodetect lib dirs and import xtables

… level errors

Autodetect lib dirs and import xtables
@ldx
Copy link
Owner

ldx commented Apr 1, 2018

@vintozver the tests on Travis failed, can you take a look?

@vintozver
Copy link
Contributor Author

stdin=subprocess.DEVNULL, stdout=subprocess.PIPE, stderr=subprocess.DEVNULL, universal_newlines=True
AttributeError: 'module' object has no attribute 'DEVNULL'

will fix now

@coveralls
Copy link

coveralls commented Apr 1, 2018

Coverage Status

Coverage increased (+0.02%) to 59.412% when pulling 971c44d on vintozver:master into b722987 on ldx:master.

@vintozver
Copy link
Contributor Author

vintozver commented Apr 1, 2018

tests are now passing, sorry for the mess :)

@vintozver vintozver closed this Apr 2, 2018
@vintozver vintozver reopened this Apr 2, 2018
@ldx ldx merged commit ececff1 into ldx:master Apr 3, 2018
@ldx
Copy link
Owner

ldx commented Apr 3, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants